summaryrefslogtreecommitdiffstats
path: root/tests/bugs
diff options
context:
space:
mode:
authorShyam <srangana@redhat.com>2014-08-29 15:20:40 -0400
committerVijay Bellur <vbellur@redhat.com>2014-09-02 11:46:09 -0700
commit4ce3db8e508e715a43352b082e861fd0e729951f (patch)
tree489d4e0489961f00c68be6692056826a209148ec /tests/bugs
parent890ab583a519b3b189a61c5fd563b4326836b988 (diff)
cluster/dht: Rename should not fail post hardlink creation
In the rename path, we wind the creation of newname hardlink and linkto file in dst hashed a the same time. If the linkto creation fails, but the link creation succeeds, we enter the failure code and cleanup the created newname hardlink. In the interim if another client looks up newname and finds it as a hardlink from FUSE, it could send an unlink for oldname instead of a rename. This combined with the above cleanup code could end up losing all the files copies, and thereby losing data. This fix separates these steps into 2 parts, creating the linkto first and then the link file, so that post link file creation no failures would cleanup the newname file. If linkto fails then link is not attempted, thereby not polluting the name space with newname. Change-Id: I61da8e906060da16a31ea1076eec2f01fd617f44 BUG: 1130888 Signed-off-by: Shyam <srangana@redhat.com> Reviewed-on: http://review.gluster.org/8570 Tested-by: Gluster Build System <jenkins@build.gluster.com> Reviewed-by: Jeff Darcy <jdarcy@redhat.com> Reviewed-by: Vijay Bellur <vbellur@redhat.com>
Diffstat (limited to 'tests/bugs')
0 files changed, 0 insertions, 0 deletions