diff options
| author | Jeff Darcy <jdarcy@redhat.com> | 2015-03-25 09:21:06 -0400 |
|---|---|---|
| committer | Shyamsundar Ranganathan <srangana@redhat.com> | 2015-03-26 11:44:52 -0700 |
| commit | 02c045790136fc6e979a82d4d7fa8d1d298478fb (patch) | |
| tree | a97f5190933206f731043867865a945a13f6b430 /tests/dht.rc | |
| parent | c54e546040a15d6f1751816f59bdfba430b5fde3 (diff) | |
tests: fix rebalance_completed
This was causing spurious faiures in bug-884455.t and possibly
elsewhere.
Change-Id: Iad6b7515ca0c7c485300f79dcd2477efc76877f8
BUG: 1163543
Signed-off-by: Jeff Darcy <jdarcy@redhat.com>
Reviewed-on: http://review.gluster.org/9994
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Shyamsundar Ranganathan <srangana@redhat.com>
Diffstat (limited to 'tests/dht.rc')
| -rw-r--r-- | tests/dht.rc | 6 |
1 files changed, 5 insertions, 1 deletions
diff --git a/tests/dht.rc b/tests/dht.rc index 4d4979ea082..45bb27661c6 100644 --- a/tests/dht.rc +++ b/tests/dht.rc @@ -76,7 +76,11 @@ function rebalance_completed() fi echo $val - return $val + # Do not *return* the value here. If it's non-zero, that will cause + # EXPECT_WITHIN (e.g. in bug-884455.t) to return prematurely, leading to + # a spurious test failure. Nothing else checks the return value anyway + # (they all check the output) so there's no need for it to be non-zero + # just because grep didn't find what we want. } function remove_brick_completed() |