diff options
author | Xavier Hernandez <xhernandez@datalab.es> | 2015-05-21 18:45:12 +0200 |
---|---|---|
committer | Pranith Kumar Karampuri <pkarampu@redhat.com> | 2015-05-27 03:24:38 -0700 |
commit | 5513144feb5b062b733d7514adf194429e31666f (patch) | |
tree | 7ec8117f5b44f4c8339947740920e9e610149c7c /tests/volume.rc | |
parent | d37cb5aee7af8582d0343d2732c153226955945d (diff) |
posix: Do not update unmodified xattr in (f)xattrop
If a (f)xattrop is issued with a value that only contains 0's,
then we don't modify or create the extended attribute. This
is useful to avoid ctime modifications when the only purpose
of the xattrop was to get the current value.
Change-Id: Ia62494e9009962e683c8276783f671da17a8b03a
BUG: 1211123
Signed-off-by: Xavier Hernandez <xhernandez@datalab.es>
Reviewed-on: http://review.gluster.org/10886
Tested-by: NetBSD Build System
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Pranith Kumar Karampuri <pkarampu@redhat.com>
Diffstat (limited to 'tests/volume.rc')
-rw-r--r-- | tests/volume.rc | 6 |
1 files changed, 5 insertions, 1 deletions
diff --git a/tests/volume.rc b/tests/volume.rc index 9e01fff687d..5a7d0343a14 100644 --- a/tests/volume.rc +++ b/tests/volume.rc @@ -209,7 +209,11 @@ function check_option_help_presence { function afr_get_changelog_xattr { local file=$1 local xkey=$2 - getfattr -n $xkey -e hex $file 2>/dev/null | grep "$xkey" | cut -f2 -d'=' + local xval=$(getfattr -n $xkey -e hex $file 2>/dev/null | grep "$xkey" | cut -f2 -d'=') + if [ -z $xval ]; then + xval="0x000000000000000000000000" + fi + echo $xval } function afr_get_pending_heal_count { |