diff options
| author | Poornima G <pgurusid@redhat.com> | 2017-05-26 15:45:57 +0530 |
|---|---|---|
| committer | Atin Mukherjee <amukherj@redhat.com> | 2017-06-13 05:01:17 +0000 |
| commit | 7674584fa53944a4e982e217798f31a3d1ef313b (patch) | |
| tree | e3729576373927b49409bcd6520f78aa579d46d5 /tests | |
| parent | 05b2fbd077cadc409994762e346ef94f4904545b (diff) | |
nl-cache: Fix a possible crash and stale cache
Issue1:
Consider the followinf sequence of operations:
...
nlc_ctx = nlc_ctx_get (inode i1)
....... -> nlc_clear_cache (i1) gets called as a part of nlc_invalidate
or any other callers
...
GF_FREE (ii nlc_ctx)
LOCK (nlc_ctx->lock); -> This will result in crash as the ctx
got freed in nlc_clear_cache.
Issue2:
lookup on dir1/file1 result in ENOENT
add cache to dir1 at time T1
....
CHILD_DOWN at T2
lookup on dir1/file2 result in ENOENT
add cache to dir1, but the cache time is still T1
lookup on dir1/file2 - should have been served from cache
but the cache time is T1 < T2, hence
cache is considered as invalid.
So, after CHILD_DOWN the right thing would be to clear the cache
and restart caching on that inode.
Solution:
Do not free nlc_ctx in nlc_clear_cache, but only in inode_forget()
The fix for both issue1 and 2 is interleaved hence sending it as
single patch.
Change-Id: I83d8ed36c049a93567c6d7e63d045dc14ccbb397
BUG: 1458539
Signed-off-by: Poornima G <pgurusid@redhat.com>
Reviewed-on: https://review.gluster.org/17453
Smoke: Gluster Build System <jenkins@build.gluster.org>
NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
Reviewed-by: Pranith Kumar Karampuri <pkarampu@redhat.com>
CentOS-regression: Gluster Build System <jenkins@build.gluster.org>
Diffstat (limited to 'tests')
| -rwxr-xr-x | tests/basic/nl-cache.t | 1 |
1 files changed, 1 insertions, 0 deletions
diff --git a/tests/basic/nl-cache.t b/tests/basic/nl-cache.t index f61532879b2..2979a9be0d4 100755 --- a/tests/basic/nl-cache.t +++ b/tests/basic/nl-cache.t @@ -16,6 +16,7 @@ EXPECT 'on' volinfo_field $V0 'performance.nl-cache' EXPECT '600' volinfo_field $V0 'features.cache-invalidation-timeout' EXPECT 'on' volinfo_field $V0 'features.cache-invalidation' EXPECT '50000' volinfo_field $V0 'network.inode-lru-limit' +TEST $CLI volume set $V0 nl-cache-positive-entry on TEST $CLI volume start $V0; EXPECT 'Started' volinfo_field $V0 'Status'; |