diff options
| author | Raghavendra Bhat <raghavendra@redhat.com> | 2013-02-19 13:22:25 +0530 |
|---|---|---|
| committer | Vijay Bellur <vbellur@redhat.com> | 2013-03-05 02:22:46 -0800 |
| commit | fe042ba81ee4b14e0450226bdc2ac2bd00d1e698 (patch) | |
| tree | 589df546a3f41f7b5e4073f8811b2cf847a472c3 /xlators/cluster/afr/src/afr-common.c | |
| parent | da9a63e66d4a22135811f1c548124e07c2a466c0 (diff) | |
cluster/afr: do complete split-brain check in all the fd based fops
fd based operations such as readv checked only for data split brain
instead of complete split-brain (i.e both data + metadata) assuming that
open would have done the complete split-brain check. However open-behind
would have unwound open, without winding to afr thus preventing the complete
split-brain check and some appliations will be able to read the contents
of the file even though the file has metadata split-brain. So let all
the fd based fops do a defensive check of complete split-brain.
Change-Id: I0ea52f782b371ce73e8e1c61f9def438fce1bd28
BUG: 846240
Signed-off-by: Raghavendra Bhat <raghavendra@redhat.com>
Reviewed-on: http://review.gluster.org/4620
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Vijay Bellur <vbellur@redhat.com>
Diffstat (limited to 'xlators/cluster/afr/src/afr-common.c')
| -rw-r--r-- | xlators/cluster/afr/src/afr-common.c | 15 |
1 files changed, 0 insertions, 15 deletions
diff --git a/xlators/cluster/afr/src/afr-common.c b/xlators/cluster/afr/src/afr-common.c index 801346406d7..e66be0358c9 100644 --- a/xlators/cluster/afr/src/afr-common.c +++ b/xlators/cluster/afr/src/afr-common.c @@ -325,21 +325,6 @@ out: } gf_boolean_t -afr_is_data_split_brain (xlator_t *this, inode_t *inode) -{ - afr_inode_ctx_t *ctx = NULL; - gf_boolean_t spb = _gf_false; - - ctx = afr_inode_ctx_get (inode, this); - if (!ctx) - goto out; - if (ctx->data_spb == SPB) - spb = _gf_true; -out: - return spb; -} - -gf_boolean_t afr_is_opendir_done (xlator_t *this, inode_t *inode) { afr_inode_params_t params = {0}; |