diff options
author | Pranith Kumar K <pkarampu@redhat.com> | 2014-09-13 12:08:56 +0530 |
---|---|---|
committer | Vijay Bellur <vbellur@redhat.com> | 2014-09-24 10:38:57 -0700 |
commit | dd80d06145a5911e697b724a44fd4d858e3a9134 (patch) | |
tree | e0f5ce6cf128a3e9f925b578e2f5ce69710a0dc3 /xlators/cluster/afr/src/afr-common.c | |
parent | 3b4664d7aa8eda5011fedeaeaad3281c1b06a517 (diff) |
cluster/afr: Fix spurious metadata self-healsv3.6.0beta2
Backport of http://review.gluster.org/8709
- Added logging for metadata and data self-heals which helped
in debugging this issue.
- Added checks to skip self-heals when no sinks are available to heal
BUG: 1145987
Change-Id: Ide03af4f531a1280ec8ad95b627285df4d7bc42d
Signed-off-by: Pranith Kumar K <pkarampu@redhat.com>
Reviewed-on: http://review.gluster.org/8832
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Vijay Bellur <vbellur@redhat.com>
Diffstat (limited to 'xlators/cluster/afr/src/afr-common.c')
-rw-r--r-- | xlators/cluster/afr/src/afr-common.c | 7 |
1 files changed, 4 insertions, 3 deletions
diff --git a/xlators/cluster/afr/src/afr-common.c b/xlators/cluster/afr/src/afr-common.c index d1bce6284a8..3e745e2491e 100644 --- a/xlators/cluster/afr/src/afr-common.c +++ b/xlators/cluster/afr/src/afr-common.c @@ -1198,8 +1198,8 @@ xattr_is_equal (dict_t *this, char *key1, data_t *value1, void *data) * We need to do both because ignoring glusterfs' internal xattrs * happens only in xattr_is_equal(). */ -static gf_boolean_t -dicts_are_equal (dict_t *dict1, dict_t *dict2) +gf_boolean_t +afr_xattrs_are_equal (dict_t *dict1, dict_t *dict2) { int ret = 0; @@ -1596,7 +1596,8 @@ afr_can_start_metadata_self_heal(call_frame_t *frame, xlator_t *this) } /*Check if xattrs need heal*/ - if (!dicts_are_equal (replies[first].xdata, replies[i].xdata)) + if (!afr_xattrs_are_equal (replies[first].xdata, + replies[i].xdata)) start = _gf_true; } |