diff options
author | Ravishankar N <ravishankar@redhat.com> | 2017-11-13 07:03:36 +0530 |
---|---|---|
committer | Ravishankar N <ravishankar@redhat.com> | 2017-11-24 03:49:33 +0000 |
commit | 2559d959df1a5dec10b0b80ba5ac0ec292014d8e (patch) | |
tree | acf1fa1c0bd1c0e858f97fd2790e82849d4aee44 /xlators/cluster/afr/src/afr-self-heal-common.c | |
parent | e19f5c34a5bef2f5d097ee359100c3fd43fd310a (diff) |
afr: coverity fixes
1.afr_discover_do: COPY_PASTE_ERROR
2.afr_fav_child_reset_sink_xattrs_cbk: REVERSE_INULL
3.afr_fop_lock_proceed: UNUSED_VALUE
4.afr_local_init: CHECKED_RETURN
5.afr_set_split_brain_choice: REVERSE_INULL
6.__afr_inode_write_finalize: FORWARD_NULL
7.afr_refresh_heal_done: REVERSE_INULL
8.afr_xl_op:UNUSED_VALUE
9.afr_changelog_populate_xdata: DEADCODE
10.set_afr_pending_xattrs_option: RESOURCE_LEAK
Note:
RESOURCE_LEAK complaints about afr_fgetxattr_pathinfo_cbk,
afr_getxattr_list_node_uuids_cbk and afr_getxattr_pathinfo_cbk seem to
be false alarms.
Change-Id: Ia4ca1478b5e2922084732d14c1e7b1b03ad5ac45
BUG: 789278
Signed-off-by: Ravishankar N <ravishankar@redhat.com>
Diffstat (limited to 'xlators/cluster/afr/src/afr-self-heal-common.c')
-rw-r--r-- | xlators/cluster/afr/src/afr-self-heal-common.c | 3 |
1 files changed, 1 insertions, 2 deletions
diff --git a/xlators/cluster/afr/src/afr-self-heal-common.c b/xlators/cluster/afr/src/afr-self-heal-common.c index 26d3860b234..8e75d200567 100644 --- a/xlators/cluster/afr/src/afr-self-heal-common.c +++ b/xlators/cluster/afr/src/afr-self-heal-common.c @@ -2557,8 +2557,7 @@ afr_refresh_heal_done (int ret, call_frame_t *frame, void *opaque) } UNLOCK (&priv->lock); - if (heal_frame) - AFR_STACK_DESTROY (heal_frame); + AFR_STACK_DESTROY (heal_frame); if (local) afr_heal_synctask (this, local); |