diff options
author | Pranith Kumar K <pkarampu@redhat.com> | 2014-09-13 12:08:56 +0530 |
---|---|---|
committer | Vijay Bellur <vbellur@redhat.com> | 2014-09-24 10:38:57 -0700 |
commit | dd80d06145a5911e697b724a44fd4d858e3a9134 (patch) | |
tree | e0f5ce6cf128a3e9f925b578e2f5ce69710a0dc3 /xlators/cluster/afr/src/afr-self-heal-common.c | |
parent | 3b4664d7aa8eda5011fedeaeaad3281c1b06a517 (diff) |
cluster/afr: Fix spurious metadata self-healsv3.6.0beta2
Backport of http://review.gluster.org/8709
- Added logging for metadata and data self-heals which helped
in debugging this issue.
- Added checks to skip self-heals when no sinks are available to heal
BUG: 1145987
Change-Id: Ide03af4f531a1280ec8ad95b627285df4d7bc42d
Signed-off-by: Pranith Kumar K <pkarampu@redhat.com>
Reviewed-on: http://review.gluster.org/8832
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Vijay Bellur <vbellur@redhat.com>
Diffstat (limited to 'xlators/cluster/afr/src/afr-self-heal-common.c')
-rw-r--r-- | xlators/cluster/afr/src/afr-self-heal-common.c | 32 |
1 files changed, 32 insertions, 0 deletions
diff --git a/xlators/cluster/afr/src/afr-self-heal-common.c b/xlators/cluster/afr/src/afr-self-heal-common.c index b104e6b7869..b855f98ddf2 100644 --- a/xlators/cluster/afr/src/afr-self-heal-common.c +++ b/xlators/cluster/afr/src/afr-self-heal-common.c @@ -384,6 +384,38 @@ afr_selfheal_find_direction (xlator_t *this, struct afr_reply *replies, return 0; } +void +afr_log_selfheal (uuid_t gfid, xlator_t *this, int ret, char *type, + int source, unsigned char *healed_sinks) +{ + char *status = NULL; + char *sinks_str = NULL; + char *p = NULL; + afr_private_t *priv = NULL; + gf_loglevel_t loglevel = GF_LOG_NONE; + int i = 0; + + priv = this->private; + sinks_str = alloca0 (priv->child_count * 8); + p = sinks_str; + for (i = 0; i < priv->child_count; i++) { + if (!healed_sinks[i]) + continue; + p += sprintf (p, "%d ", i); + } + + if (ret < 0) { + status = "Failed"; + loglevel = GF_LOG_DEBUG; + } else { + status = "Completed"; + loglevel = GF_LOG_INFO; + } + + gf_log (this->name, loglevel, "%s %s selfheal on %s. " + "source=%d sinks=%s", status, type, uuid_utoa (gfid), + source, sinks_str); +} int afr_selfheal_discover_cbk (call_frame_t *frame, void *cookie, xlator_t *this, |