diff options
| author | Pranith Kumar K <pranithk@gluster.com> | 2011-09-02 08:50:48 +0530 |
|---|---|---|
| committer | Anand Avati <avati@gluster.com> | 2011-09-08 20:33:55 -0700 |
| commit | 550148f3bb3505335909cde9e937c2362a1e67e3 (patch) | |
| tree | c84f99aef6ab39f2d8c3fad8a6ae11e90fdd8014 /xlators/cluster/afr/src/afr-self-heal-data.c | |
| parent | 4d2afaae2f3c42b710acf8c7ebdb4b50d502b813 (diff) | |
cluster/afr: Make data selfheal trigger to be configurable.
By default, lookup triggers data self-heal but that is not the preferred way
of operating replicated volumes. We would like the data self heals to be
triggered in open instead.
Number of back-ground self-heals allowed is 16 and lookups block until
self-heal is completed. We want to prevent blocking in fops. We can not make
lookups independent of self-heal frames because when there are gfid conflicts
the decision of which file is correct is determined in self-heal phase.
So in afr, lookup self-heal is going to guarantee name space consistency
and open/fd fops will take responsibility for data consistency, these
are non blocking. The user needs to set the option cluster.data-self-heal
"open" for this behavior.
Change-Id: If9463cdb9ebac114708558ec13bbca0270acd659
BUG: 3503
Reviewed-on: http://review.gluster.com/334
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Anand Avati <avati@gluster.com>
Diffstat (limited to 'xlators/cluster/afr/src/afr-self-heal-data.c')
| -rw-r--r-- | xlators/cluster/afr/src/afr-self-heal-data.c | 3 |
1 files changed, 2 insertions, 1 deletions
diff --git a/xlators/cluster/afr/src/afr-self-heal-data.c b/xlators/cluster/afr/src/afr-self-heal-data.c index cbc6d6e39a1..216017cbb17 100644 --- a/xlators/cluster/afr/src/afr-self-heal-data.c +++ b/xlators/cluster/afr/src/afr-self-heal-data.c @@ -1336,7 +1336,8 @@ afr_self_heal_data (call_frame_t *frame, xlator_t *this) local = frame->local; sh = &local->self_heal; - if (sh->need_data_self_heal && priv->data_self_heal) { + if (sh->do_data_self_heal && + afr_data_self_heal_enabled (priv->data_self_heal)) { afr_sh_data_open (frame, this); } else { gf_log (this->name, GF_LOG_TRACE, |