diff options
author | Ravishankar N <ravishankar@redhat.com> | 2018-01-28 13:50:47 +0530 |
---|---|---|
committer | Shyamsundar Ranganathan <srangana@redhat.com> | 2018-02-06 14:25:14 +0000 |
commit | 28c306026982d559827c9dfa6ac3066dd5cd4ca1 (patch) | |
tree | 61685fb0ce3fe2b64d142d2dd15cfecb0263cb94 /xlators/cluster/afr/src/afr-transaction.c | |
parent | ce648055268469c94596679bda615d333aa9e752 (diff) |
afr: don't treat all cases all bricks being blamed as split-brain
Problem:
We currently don't have a roll-back/undoing of post-ops if quorum is not
met. Though the FOP is still unwound with failure, the xattrs remain on
the disk. Due to these partial post-ops and partial heals (healing only when
2 bricks are up), we can end up in split-brain purely from the afr
xattrs point of view i.e each brick is blamed by atleast one of the
others. These scenarios are hit when there is frequent
connect/disconnect of the client/shd to the bricks while I/O or heal
are in progress.
Fix:
Instead of undoing the post-op, pick a source based on the xattr values.
If 2 bricks blame one, the blamed one must be treated as sink.
If there is no majority, all are sources. Once we pick a source,
self-heal will then do the heal instead of erroring out due to
split-brain.
Change-Id: I3d0224b883eb0945785ade0e9697a1c828aec0ae
BUG: 1542380
Signed-off-by: Ravishankar N <ravishankar@redhat.com>
(cherry picked from commit 0e6e8216823c2d9dafb81aae0f6ee3497c23d140)
Diffstat (limited to 'xlators/cluster/afr/src/afr-transaction.c')
0 files changed, 0 insertions, 0 deletions