cluster/afr: Remove eager-lock stub on finodelk failure

Problem:
For write fops afr's transaction eager-lock init adds transactions
that can share eager-lock to fdctx list. But if eager-lock finodelk
fop fails the stub remains in the list. This could later lead to
corruption of the list and lead to infinite loop on the list
leading to a mount hang.

Fix:
Remove the stub when finodelk fails.

Change-Id: Ic9d1368907c32edb4ea2e6db623e869e4f50180d
BUG: 1063190
Signed-off-by: Pranith Kumar K <pkarampu@redhat.com>
Reviewed-on: http://review.gluster.org/7748
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Niels de Vos <ndevos@redhat.com>
Tested-by: Niels de Vos <ndevos@redhat.com>

1 files changed, 2 insertions, 6 deletions

diff --git a/xlators/cluster/afr/src/afr-transaction.c b/xlators/cluster/afr/src/afr-transaction.c
index 91af75b503b..01839f5e8d8 100644
--- a/xlators/cluster/afr/src/afr-transaction.c
+++ b/xlators/cluster/afr/src/afr-transaction.c
@@ -1914,7 +1914,7 @@ afr_delayed_changelog_wake_up (xlator_t *this, fd_t *fd)
 }
 
 
-        int
+int
 afr_transaction_resume (call_frame_t *frame, xlator_t *this)
 {
         afr_internal_lock_t *int_lock = NULL;
@@ -1929,11 +1929,7 @@ afr_transaction_resume (call_frame_t *frame, xlator_t *this)
                 /* We don't need to retain "local" in the
                    fd list anymore, writes to all subvols
                    are finished by now */
-                LOCK (&local->fd->lock);
-                {
-                        list_del_init (&local->transaction.eager_locked);
-                }
-                UNLOCK (&local->fd->lock);
+                afr_remove_eager_lock_stub (local);
         }
 
         afr_restore_lk_owner (frame);