diff options
author | Anand Avati <avati@redhat.com> | 2013-04-04 19:35:11 -0700 |
---|---|---|
committer | Anand Avati <avati@redhat.com> | 2013-04-05 17:47:16 -0700 |
commit | 6f6744730e34fa8a161b5f7f2a8ad3f8a7fc30fa (patch) | |
tree | a0de6ae7d951a09f4f888e5ed8abe130cb6730f9 /xlators/cluster/afr/src/afr.h | |
parent | 862b1164525b8a6d4f8d49b3049093847533f819 (diff) |
afr: let eager-locking do its own overlap checks
Today there is a non-obvious dependence of eager-locking on
write-behind. The reason is that eager-locking works as long
as the inheriting transaction has no overlaps with any of the
transactions already in progress. While write-behind provides
non-overlapping writes as a side-effect most of times (and only
guarantees it when strict-write-ordering option is enabled,
which is not on by default) eager-lock needs the behavior
as a guarantee. This is leading to complex and unwanted checks
for the presence of write-behind in the graph, for the simple
task of checking for overlaps.
This patch removes the interdependence between eager-locking
and write-behind by making eager-locking do its own overlap checks
with in-progress writes.
Change-Id: Iccba1185aeb5f1e7f060089c895a62840787133f
BUG: 912581
Signed-off-by: Anand Avati <avati@redhat.com>
Reviewed-on: http://review.gluster.org/4782
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Pranith Kumar Karampuri <pkarampu@redhat.com>
Diffstat (limited to 'xlators/cluster/afr/src/afr.h')
-rw-r--r-- | xlators/cluster/afr/src/afr.h | 4 |
1 files changed, 4 insertions, 0 deletions
diff --git a/xlators/cluster/afr/src/afr.h b/xlators/cluster/afr/src/afr.h index 24bd20f136b..387ed12ec2f 100644 --- a/xlators/cluster/afr/src/afr.h +++ b/xlators/cluster/afr/src/afr.h @@ -677,6 +677,7 @@ typedef struct _afr_local { of the transaction frame */ call_stub_t *resume_stub; + struct list_head eager_locked; int32_t **txn_changelog;//changelog after pre+post ops unsigned char *pre_op; @@ -744,6 +745,9 @@ typedef struct { (i.e, without O_SYNC or O_DSYNC) */ gf_boolean_t witnessed_unstable_write; + + /* list of frames currently in progress */ + struct list_head eager_locked; } afr_fd_ctx_t; |