diff options
| author | Pranith Kumar K <pkarampu@redhat.com> | 2016-10-18 15:16:17 +0530 |
|---|---|---|
| committer | Pranith Kumar Karampuri <pkarampu@redhat.com> | 2016-11-23 21:44:51 -0800 |
| commit | 66f5c8a6f06c389cfb8b845254d3033f2b22801a (patch) | |
| tree | 4b04ef958d765aa0c0692ecd30ff49c32740fbf7 /xlators/cluster/afr | |
| parent | 73b0debb4f489f671e3fcd33b2c70ca9f3a2b70a (diff) | |
events: Add FMT_WARN for gf_event
Raghavendra G found that posix is trying to print %s
but passing an int when HEALTH_CHECK fails in posix.
These are the kind of bugs that should be caught
at compilation itself.
Also fixed the problematic gf_event() callers.
>BUG: 1386097
>Change-Id: Id7bd6d9a9690237cec3ca1aefa2aac085e8a1270
>Signed-off-by: Pranith Kumar K <pkarampu@redhat.com>
>Reviewed-on: http://review.gluster.org/15671
>Smoke: Gluster Build System <jenkins@build.gluster.org>
>NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
>Reviewed-by: Atin Mukherjee <amukherj@redhat.com>
>CentOS-regression: Gluster Build System <jenkins@build.gluster.org>
BUG: 1396778
Change-Id: Idf8e1f427578d02dccd2a8165884a5cf086eb07e
Signed-off-by: Pranith Kumar K <pkarampu@redhat.com>
Reviewed-on: http://review.gluster.org/15884
Smoke: Gluster Build System <jenkins@build.gluster.org>
NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
CentOS-regression: Gluster Build System <jenkins@build.gluster.org>
Reviewed-by: Atin Mukherjee <amukherj@redhat.com>
Diffstat (limited to 'xlators/cluster/afr')
| -rw-r--r-- | xlators/cluster/afr/src/afr-self-heal-common.c | 5 |
1 files changed, 4 insertions, 1 deletions
diff --git a/xlators/cluster/afr/src/afr-self-heal-common.c b/xlators/cluster/afr/src/afr-self-heal-common.c index 556bc5d250e..b6720ccfa5c 100644 --- a/xlators/cluster/afr/src/afr-self-heal-common.c +++ b/xlators/cluster/afr/src/afr-self-heal-common.c @@ -1604,6 +1604,7 @@ afr_selfheal_unlocked_inspect (call_frame_t *frame, xlator_t *this, int i = 0; int valid_cnt = 0; struct iatt first = {0, }; + int first_idx = 0; struct afr_reply *replies = NULL; int ret = -1; @@ -1643,6 +1644,7 @@ afr_selfheal_unlocked_inspect (call_frame_t *frame, xlator_t *this, valid_cnt++; if (valid_cnt == 1) { first = replies[i].poststat; + first_idx = i; continue; } @@ -1658,7 +1660,8 @@ afr_selfheal_unlocked_inspect (call_frame_t *frame, xlator_t *this, "type=file;gfid=%s;" "ia_type-%d=%s;ia_type-%d=%s", this->name, - uuid_utoa (replies[i].poststat.ia_gfid), first, + uuid_utoa (replies[i].poststat.ia_gfid), + first_idx, gf_inode_type_to_str (first.ia_type), i, gf_inode_type_to_str (replies[i].poststat.ia_type)); ret = -EIO; |