summaryrefslogtreecommitdiffstats
path: root/xlators/cluster/dht/src/dht-common.c
diff options
context:
space:
mode:
authorMohammed Rafi KC <rkavunga@redhat.com>2015-09-04 19:46:48 +0530
committerRaghavendra G <rgowdapp@redhat.com>2015-09-08 22:27:22 -0700
commit04b5fe0f6ab32bafeefc30558e259cb47e1b71f3 (patch)
treef827bcd76f3055ff0c48c02dcadd41eb6e9b1539 /xlators/cluster/dht/src/dht-common.c
parentccb52e0cba557a792b9227c86155a2dc8e29f44f (diff)
dht: NULL dereferencing causes crash
If linkfile_create is failed for some reason, then we are trying to dereference a null variable Change-Id: I3c6ff3715821b9b993d1bab7b90167de2861e190 BUG: 1260147 Signed-off-by: Mohammed Rafi KC <rkavunga@redhat.com> Reviewed-on: http://review.gluster.org/12106 Reviewed-by: Susant Palai <spalai@redhat.com> Reviewed-by: N Balachandran <nbalacha@redhat.com> Tested-by: Gluster Build System <jenkins@build.gluster.com> Reviewed-by: Raghavendra G <rgowdapp@redhat.com>
Diffstat (limited to 'xlators/cluster/dht/src/dht-common.c')
-rw-r--r--xlators/cluster/dht/src/dht-common.c4
1 files changed, 2 insertions, 2 deletions
diff --git a/xlators/cluster/dht/src/dht-common.c b/xlators/cluster/dht/src/dht-common.c
index c0241e94928..bb97e1007ad 100644
--- a/xlators/cluster/dht/src/dht-common.c
+++ b/xlators/cluster/dht/src/dht-common.c
@@ -5038,10 +5038,10 @@ dht_mknod_linkfile_create_cbk (call_frame_t *frame, void *cookie,
dht_local_t *local = NULL;
xlator_t *cached_subvol = NULL;
+ local = frame->local;
if (op_ret == -1)
goto err;
- local = frame->local;
if (!local || !local->cached_subvol) {
op_errno = EINVAL;
goto err;
@@ -5836,12 +5836,12 @@ dht_create_linkfile_create_cbk (call_frame_t *frame, void *cookie,
dht_local_t *local = NULL;
xlator_t *cached_subvol = NULL;
+ local = frame->local;
if (op_ret == -1) {
local->op_errno = op_errno;
goto err;
}
- local = frame->local;
cached_subvol = local->cached_subvol;
STACK_WIND (frame, dht_create_cbk,