diff options
author | Niels de Vos <ndevos@redhat.com> | 2017-07-10 11:45:31 +0200 |
---|---|---|
committer | Niels de Vos <ndevos@redhat.com> | 2017-07-12 09:01:12 +0000 |
commit | a4a417e29c5b2d63e6bf5efae4f0ccf30a39647f (patch) | |
tree | 0df516d8d8f0f89789c91dd447c2650e5f52338b /xlators/cluster/dht/src | |
parent | 9ab249130a5dd442044e787f1e171e7a17839906 (diff) |
gfapi: prevent mem-pool leak in case glfs_new_fs() fails
Commit 7039243e187 adds a call to mem_pools_init() so that the memory
pool cleanup thread ("sweeper") is started. However, now it is possible
that users of gfapi can not cleanup this thread because glfs_new() can
return NULL, but the sweeper is still running.
In case glfs_fs_new() fails, mem_pools_fini() needs to be called as
well. This seems more correct than calling mem_pools_init() after
glfs_fs_new(), and this makes using memory pools possible *really* early
in the gfapi initialization.
Change-Id: I1f2fb25cc33e227b3c33ce9d1b03f67bc27e981a
Fixes: 7039243e187 ("gfapi: add mem_pools_init and mem_pools_fini calls")
BUG: 1468863
Signed-off-by: Niels de Vos <ndevos@redhat.com>
Reviewed-on: https://review.gluster.org/17734
Reviewed-by: Jeff Darcy <jeff@pl.atyp.us>
Reviewed-by: Vijay Bellur <vbellur@redhat.com>
CentOS-regression: Gluster Build System <jenkins@build.gluster.org>
Smoke: Gluster Build System <jenkins@build.gluster.org>
Reviewed-by: soumya k <skoduri@redhat.com>
Reviewed-by: Amar Tumballi <amarts@redhat.com>
Diffstat (limited to 'xlators/cluster/dht/src')
0 files changed, 0 insertions, 0 deletions