summaryrefslogtreecommitdiffstats
path: root/xlators/cluster/ec/src/ec-inode-read.c
diff options
context:
space:
mode:
authorXavier Hernandez <xhernandez@datalab.es>2014-08-04 20:50:31 +0200
committerVijay Bellur <vbellur@redhat.com>2014-09-11 22:44:12 -0700
commit26be0b3a9f334f33f1a6e53706045eb02983d713 (patch)
treec72f6018f60940d1da31ad50d4f2344555a959bf /xlators/cluster/ec/src/ec-inode-read.c
parent5157914bac0da41cba8fef10f9dfaef209e6e865 (diff)
ec: Removed SSE2 dependency
This patch implements the Galois Field multiplications using pure C code without any assembler support. This makes the ec xlator portable to other architectures. In the future it will be possible to use an optimized implementation of the multiplications using architecture dependent facilities (it will be automatically detected and configured). To allow bricks with different machine word sizes to be able to work seamlessly in the same volume, the minimum fragment length to be stored in any brick has been fixed to 512 bytes. Otherwise, different implementations will corrupt the data (SSE2 used 128 bytes, while new implementation would have used 64). This patch also removes the '-msse2' option added on patch http://review.gluster.org/8395/ Change-Id: Iaf6e4ef3dcfda6c68f48f16ca46fc4fb61a215f4 BUG: 1125166 Signed-off-by: Xavier Hernandez <xhernandez@datalab.es> Reviewed-on: http://review.gluster.org/8413 Tested-by: Gluster Build System <jenkins@build.gluster.com> Reviewed-by: Dan Lambright <dlambrig@redhat.com>
Diffstat (limited to 'xlators/cluster/ec/src/ec-inode-read.c')
-rw-r--r--xlators/cluster/ec/src/ec-inode-read.c18
1 files changed, 9 insertions, 9 deletions
diff --git a/xlators/cluster/ec/src/ec-inode-read.c b/xlators/cluster/ec/src/ec-inode-read.c
index 484c5e40189..a31220ecbc1 100644
--- a/xlators/cluster/ec/src/ec-inode-read.c
+++ b/xlators/cluster/ec/src/ec-inode-read.c
@@ -975,7 +975,7 @@ int32_t ec_readv_rebuild(ec_t * ec, ec_fop_data_t * fop, ec_cbk_data_t * cbk)
ec_cbk_data_t * ans = NULL;
struct iobref * iobref = NULL;
struct iobuf * iobuf = NULL;
- uint8_t * ptr = NULL, * buff = NULL;
+ uint8_t * buff = NULL, * ptr;
size_t fsize = 0, size = 0, max = 0;
int32_t i = 0;
@@ -994,17 +994,17 @@ int32_t ec_readv_rebuild(ec_t * ec, ec_fop_data_t * fop, ec_cbk_data_t * cbk)
fsize = cbk->op_ret;
size = fsize * ec->fragments;
- ptr = GF_MALLOC(size + EC_BUFFER_ALIGN_SIZE - 1, gf_common_mt_char);
- if (ptr == NULL)
+ buff = GF_MALLOC(size, gf_common_mt_char);
+ if (buff == NULL)
{
goto out;
}
- buff = GF_ALIGN_BUF(ptr, EC_BUFFER_ALIGN_SIZE);
+ ptr = buff;
for (i = 0, ans = cbk; ans != NULL; i++, ans = ans->next)
{
values[i] = ans->idx;
- blocks[i] = buff;
- buff += ec_iov_copy_to(buff, ans->vector, ans->int32, 0, fsize);
+ blocks[i] = ptr;
+ ptr += ec_iov_copy_to(ptr, ans->vector, ans->int32, 0, fsize);
}
iobref = iobref_new();
@@ -1028,8 +1028,8 @@ int32_t ec_readv_rebuild(ec_t * ec, ec_fop_data_t * fop, ec_cbk_data_t * cbk)
iobuf_unref(iobuf);
- GF_FREE(ptr);
- ptr = NULL;
+ GF_FREE(buff);
+ buff = NULL;
vector[0].iov_base += fop->head;
vector[0].iov_len -= fop->head;
@@ -1079,7 +1079,7 @@ out:
{
iobref_unref(iobref);
}
- GF_FREE(ptr);
+ GF_FREE(buff);
return 0;
}