diff options
author | Raghavendra Talur <rtalur@redhat.com> | 2016-02-15 18:16:04 +0530 |
---|---|---|
committer | Raghavendra Talur <rtalur@redhat.com> | 2016-05-02 03:50:31 -0700 |
commit | f9614a3cb385c1a868443e99f9e50b2252f84b95 (patch) | |
tree | 20b6369931fffde673f53a080e8b34e6fba5ff1d /xlators/cluster | |
parent | d6b406b84dd840d15472b203052f7679d96dc321 (diff) |
libglusterfs: Add debug and trace logs for stack trace
Backport of http://review.gluster.org/13448
commit c4d67a8338b42d6485f49999f310cbb9ed5359c5
It has become very difficult to identify the xlator which returned
negative op_ret. Being able to just change the log level and
visualize the stack is helpful in such cases.
Change-Id: I6545b4802c1ab4d0d230d5e9e036afb2384882e1
BUG: 1330739
Signed-off-by: Raghavendra Talur <rtalur@redhat.com>
Reviewed-on: http://review.gluster.org/14099
Smoke: Gluster Build System <jenkins@build.gluster.com>
NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
CentOS-regression: Gluster Build System <jenkins@build.gluster.com>
Diffstat (limited to 'xlators/cluster')
-rw-r--r-- | xlators/cluster/dht/src/dht-common.c | 3 | ||||
-rw-r--r-- | xlators/cluster/stripe/src/stripe.c | 6 |
2 files changed, 5 insertions, 4 deletions
diff --git a/xlators/cluster/dht/src/dht-common.c b/xlators/cluster/dht/src/dht-common.c index 9dc3a1b9d5b..9a844be435e 100644 --- a/xlators/cluster/dht/src/dht-common.c +++ b/xlators/cluster/dht/src/dht-common.c @@ -3740,7 +3740,8 @@ dht_setxattr2 (xlator_t *this, xlator_t *subvol, call_frame_t *frame, int ret) return 0; err: - DHT_STACK_UNWIND (setxattr, frame, local ? local->op_ret : -1, op_errno, NULL); + DHT_STACK_UNWIND (setxattr, frame, (local ? local->op_ret : -1), + op_errno, NULL); return 0; } diff --git a/xlators/cluster/stripe/src/stripe.c b/xlators/cluster/stripe/src/stripe.c index 78479129620..287b64646c2 100644 --- a/xlators/cluster/stripe/src/stripe.c +++ b/xlators/cluster/stripe/src/stripe.c @@ -4939,9 +4939,9 @@ out: /* all entries are directories */ frame->local = NULL; STRIPE_STACK_UNWIND (readdir, frame, - local ? local->op_ret : -1, - local ? local->op_errno : EINVAL, - local ? &local->entries : NULL, + (local ? local->op_ret : -1), + (local ? local->op_errno : EINVAL), + (local ? &local->entries : NULL), NULL); gf_dirent_free (&local->entries); stripe_local_wipe (local); |