diff options
| author | Kaushal M <kaushal@redhat.com> | 2012-04-04 12:00:30 +0530 |
|---|---|---|
| committer | Anand Avati <avati@redhat.com> | 2012-06-07 11:42:10 -0700 |
| commit | 81e7464a54165b5d8b40847355d3bb6fe7b6e9df (patch) | |
| tree | 990c4864efad87fefa6f24fb7a876c28f26c4238 /xlators/cluster | |
| parent | 86ff555eaaefb616b3dde5924a40271d99314861 (diff) | |
libglusterfs : Fix validation for integer volume options.
Integer volume options which specified only the min value as 0, would not be
validated during "volume set".
The range check for an option happened only if both min and max were not 0. In
the above case, even though a minium was specified, the range check did not
happen as both min and max were 0.
To allow forced validation in such cases, a new member, "validate", has been
added to volume_options_t. This member takes the values GF_OPT_VALIDATE_BOTH,
GF_OPT_VALIDATE_MIN and GF_OPT_VALIDATE_MAX (GF_OPT_VALIDATE_BOTH is the
default).
Change-Id: I351de0eedb6028120e5c0b073ee5d9c141dee717
BUG: 809847
Signed-off-by: Kaushal M <kaushal@redhat.com>
Reviewed-on: http://review.gluster.com/3084
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Amar Tumballi <amarts@redhat.com>
Reviewed-by: Anand Avati <avati@redhat.com>
Diffstat (limited to 'xlators/cluster')
| -rw-r--r-- | xlators/cluster/afr/src/afr.c | 1 |
1 files changed, 1 insertions, 0 deletions
diff --git a/xlators/cluster/afr/src/afr.c b/xlators/cluster/afr/src/afr.c index 4f7bf2de004..ebb9f1ee904 100644 --- a/xlators/cluster/afr/src/afr.c +++ b/xlators/cluster/afr/src/afr.c @@ -524,6 +524,7 @@ struct volume_options options[] = { .type = GF_OPTION_TYPE_INT, .min = 0, .default_value = "16", + .validate = GF_OPT_VALIDATE_MIN, }, { .key = {"data-self-heal"}, .type = GF_OPTION_TYPE_STR, |