diff options
author | Kaleb S KEITHLEY <kkeithle@redhat.com> | 2015-12-18 07:44:45 -0500 |
---|---|---|
committer | Niels de Vos <ndevos@redhat.com> | 2015-12-22 09:15:01 -0800 |
commit | e62c0fe19b113d42db5e0f80fa7cbb82f2f88190 (patch) | |
tree | 584016bcf8df4069c2795d87967c9c3a7fe230ab /xlators/cluster | |
parent | 76f1680a2de05420934e131f934f3895fbe50db8 (diff) |
build: export minimum symbols from xlators for correct resolution
Revisiting http://review.gluster.org/#/c/11814/, which unintentionally
introduced warnings from libtool about the xlator .so names.
According to [1], the -module option must appear in the Makefile.am
file(s); if -module is defined in a macro, e.g. in configure(.ac),
then libtool will not recognize that this is a module and will emit a
warning.
[1]
http://www.gnu.org/software/automake/manual/automake.html#Libtool-Modules
Change-Id: Ifa5f9327d18d139597791c305aa10cc4410fb078
BUG: 1248669
Signed-off-by: Kaleb S KEITHLEY <kkeithle@redhat.com>
Reviewed-on: http://review.gluster.org/13003
Tested-by: NetBSD Build System <jenkins@build.gluster.org>
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: soumya k <skoduri@redhat.com>
Reviewed-by: Niels de Vos <ndevos@redhat.com>
Diffstat (limited to 'xlators/cluster')
-rw-r--r-- | xlators/cluster/afr/src/Makefile.am | 4 | ||||
-rw-r--r-- | xlators/cluster/ec/src/Makefile.am | 2 | ||||
-rw-r--r-- | xlators/cluster/ha/src/Makefile.am | 2 | ||||
-rw-r--r-- | xlators/cluster/map/src/Makefile.am | 2 | ||||
-rw-r--r-- | xlators/cluster/stripe/src/Makefile.am | 2 |
5 files changed, 6 insertions, 6 deletions
diff --git a/xlators/cluster/afr/src/Makefile.am b/xlators/cluster/afr/src/Makefile.am index 27384d1c317..5612733d3ed 100644 --- a/xlators/cluster/afr/src/Makefile.am +++ b/xlators/cluster/afr/src/Makefile.am @@ -10,11 +10,11 @@ AFR_SELFHEAL_SOURCES = afr-self-heal-common.c afr-self-heal-data.c \ afr-self-heal-entry.c afr-self-heal-metadata.c afr-self-heald.c \ afr-self-heal-name.c -afr_la_LDFLAGS = $(GF_XLATOR_DEFAULT_LDFLAGS) +afr_la_LDFLAGS = -module $(GF_XLATOR_DEFAULT_LDFLAGS) afr_la_SOURCES = $(afr_common_source) $(AFR_SELFHEAL_SOURCES) afr.c afr_la_LIBADD = $(top_builddir)/libglusterfs/src/libglusterfs.la -pump_la_LDFLAGS = $(GF_XLATOR_DEFAULT_LDFLAGS) +pump_la_LDFLAGS = -module $(GF_XLATOR_DEFAULT_LDFLAGS) pump_la_SOURCES = $(afr_common_source) $(AFR_SELFHEAL_SOURCES) pump.c pump_la_LIBADD = $(top_builddir)/libglusterfs/src/libglusterfs.la diff --git a/xlators/cluster/ec/src/Makefile.am b/xlators/cluster/ec/src/Makefile.am index c45a8f05713..cbdceefdbe0 100644 --- a/xlators/cluster/ec/src/Makefile.am +++ b/xlators/cluster/ec/src/Makefile.am @@ -33,7 +33,7 @@ ec_ext_sources = $(top_builddir)/xlators/lib/src/libxlator.c ec_ext_headers = $(top_builddir)/xlators/lib/src/libxlator.h -ec_la_LDFLAGS = $(GF_XLATOR_DEFAULT_LDFLAGS) +ec_la_LDFLAGS = -module $(GF_XLATOR_DEFAULT_LDFLAGS) ec_la_SOURCES = $(ec_sources) $(ec_headers) $(ec_ext_sources) $(ec_ext_headers) ec_la_LIBADD = $(top_builddir)/libglusterfs/src/libglusterfs.la diff --git a/xlators/cluster/ha/src/Makefile.am b/xlators/cluster/ha/src/Makefile.am index 4b730f9534e..740a6b840d7 100644 --- a/xlators/cluster/ha/src/Makefile.am +++ b/xlators/cluster/ha/src/Makefile.am @@ -1,7 +1,7 @@ xlator_LTLIBRARIES = ha.la xlatordir = $(libdir)/glusterfs/$(PACKAGE_VERSION)/xlator/testing/cluster -ha_la_LDFLAGS = $(GF_XLATOR_DEFAULT_LDFLAGS) +ha_la_LDFLAGS = -module $(GF_XLATOR_DEFAULT_LDFLAGS) ha_la_SOURCES = ha-helpers.c ha.c diff --git a/xlators/cluster/map/src/Makefile.am b/xlators/cluster/map/src/Makefile.am index 6f4765ff2e4..209cafa7c1b 100644 --- a/xlators/cluster/map/src/Makefile.am +++ b/xlators/cluster/map/src/Makefile.am @@ -1,7 +1,7 @@ xlator_LTLIBRARIES = map.la xlatordir = $(libdir)/glusterfs/$(PACKAGE_VERSION)/xlator/testing/cluster -map_la_LDFLAGS = $(GF_XLATOR_DEFAULT_LDFLAGS) +map_la_LDFLAGS = -module $(GF_XLATOR_DEFAULT_LDFLAGS) map_la_SOURCES = map.c map-helper.c diff --git a/xlators/cluster/stripe/src/Makefile.am b/xlators/cluster/stripe/src/Makefile.am index a4c5370562c..e732c52423c 100644 --- a/xlators/cluster/stripe/src/Makefile.am +++ b/xlators/cluster/stripe/src/Makefile.am @@ -1,7 +1,7 @@ xlator_LTLIBRARIES = stripe.la xlatordir = $(libdir)/glusterfs/$(PACKAGE_VERSION)/xlator/cluster -stripe_la_LDFLAGS = $(GF_XLATOR_DEFAULT_LDFLAGS) +stripe_la_LDFLAGS = -module $(GF_XLATOR_DEFAULT_LDFLAGS) stripe_la_SOURCES = stripe.c stripe-helpers.c \ |