summaryrefslogtreecommitdiffstats
path: root/xlators/cluster
diff options
context:
space:
mode:
authorPranith Kumar K <pkarampu@redhat.com>2016-05-04 19:05:28 +0530
committerPranith Kumar Karampuri <pkarampu@redhat.com>2016-05-05 20:50:54 -0700
commite66add8a304ca610b74ecbbe48cec72dba582340 (patch)
treea95017750eaeebea911fc1a358f076922ceea712 /xlators/cluster
parent74837896c38bafdd862f164d147b75fcbb619e8f (diff)
cluster/afr: Do heals with shd pid
Multi-threaded healing doesn't create synctask with shd pid, this leads to healing problems when quota exceeds. BUG: 1332994 Change-Id: I80f57c1923756f3298730b8820498127024e1209 Signed-off-by: Pranith Kumar K <pkarampu@redhat.com> Reviewed-on: http://review.gluster.org/14211 Smoke: Gluster Build System <jenkins@build.gluster.com> NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org> CentOS-regression: Gluster Build System <jenkins@build.gluster.com> Reviewed-by: Ravishankar N <ravishankar@redhat.com>
Diffstat (limited to 'xlators/cluster')
-rw-r--r--xlators/cluster/afr/src/afr-self-heald.c11
1 files changed, 10 insertions, 1 deletions
diff --git a/xlators/cluster/afr/src/afr-self-heald.c b/xlators/cluster/afr/src/afr-self-heald.c
index 2ec9d9ce686..545ffa0a1d7 100644
--- a/xlators/cluster/afr/src/afr-self-heald.c
+++ b/xlators/cluster/afr/src/afr-self-heald.c
@@ -430,10 +430,17 @@ afr_shd_index_sweep (struct subvol_healer *healer, char *vgfid)
int ret = 0;
xlator_t *subvol = NULL;
dict_t *xdata = NULL;
+ call_frame_t *frame = NULL;
priv = healer->this->private;
subvol = priv->children[healer->subvol];
+ frame = afr_frame_create (healer->this);
+ if (!frame) {
+ ret = -ENOMEM;
+ goto out;
+ }
+
loc.inode = afr_shd_index_inode (healer->this, subvol, vgfid);
if (!loc.inode) {
gf_msg (healer->this->name, GF_LOG_WARNING,
@@ -449,7 +456,7 @@ afr_shd_index_sweep (struct subvol_healer *healer, char *vgfid)
goto out;
}
- ret = syncop_mt_dir_scan (subvol, &loc, GF_CLIENT_PID_SELF_HEALD,
+ ret = syncop_mt_dir_scan (frame, subvol, &loc, GF_CLIENT_PID_SELF_HEALD,
healer, afr_shd_index_heal, xdata,
priv->shd.max_threads, priv->shd.wait_qlength);
@@ -461,6 +468,8 @@ out:
if (xdata)
dict_unref (xdata);
+ if (frame)
+ AFR_STACK_DESTROY (frame);
return ret;
}