diff options
| author | Jeff Darcy <jdarcy@redhat.com> | 2012-10-03 09:30:27 -0400 |
|---|---|---|
| committer | Anand Avati <avati@redhat.com> | 2012-10-03 12:24:59 -0700 |
| commit | 1ecbb7ca68bd39ede792414b21a772469ecb4094 (patch) | |
| tree | b54d1e8b7c54e6f9a03cf7ef0452c61582ba81d5 /xlators/debug | |
| parent | ec79583cfd2ae10998dedfeb0c2c2a83a81cdec3 (diff) | |
build: remove useless explicit -fPIC -shared from
CFLAGS
libtool will automatically add "-fPIC" to the compiler command line as
needed, so there is no need to specify it separately.
"-shared" is normally a linker flag and has an odd effect when used with
libtool --mode=compile, namely that it inhibits production of static
objects. For that however, using AC_DISABLE_STATIC is a lot simpler.
Change-Id: Ic4cba0fad18ffd985cf07f8d6951a976ae59a48f
BUG: 862082
Original-author: Jan Engelhardt <jengelh@inai.de>
Signed-off-by: Jan Engelhardt <jengelh@inai.de>
Signed-off-by: Jeff Darcy <jdarcy@redhat.com>
Reviewed-on: http://review.gluster.org/4027
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Anand Avati <avati@redhat.com>
Diffstat (limited to 'xlators/debug')
| -rw-r--r-- | xlators/debug/error-gen/src/Makefile.am | 4 | ||||
| -rw-r--r-- | xlators/debug/io-stats/src/Makefile.am | 4 | ||||
| -rw-r--r-- | xlators/debug/trace/src/Makefile.am | 4 |
3 files changed, 6 insertions, 6 deletions
diff --git a/xlators/debug/error-gen/src/Makefile.am b/xlators/debug/error-gen/src/Makefile.am index cef5254d5b8..c23ad62098a 100644 --- a/xlators/debug/error-gen/src/Makefile.am +++ b/xlators/debug/error-gen/src/Makefile.am @@ -9,8 +9,8 @@ error_gen_la_LIBADD = $(top_builddir)/libglusterfs/src/libglusterfs.la noinst_HEADERS = error-gen.h error-gen-mem-types.h -AM_CFLAGS = -fPIC $(GF_CPPFLAGS) -Wall \ - -I$(top_srcdir)/libglusterfs/src -shared $(GF_CFLAGS) +AM_CFLAGS = $(GF_CPPFLAGS) -Wall \ + -I$(top_srcdir)/libglusterfs/src $(GF_CFLAGS) CLEANFILES = diff --git a/xlators/debug/io-stats/src/Makefile.am b/xlators/debug/io-stats/src/Makefile.am index 2c82d57b490..b18c88be430 100644 --- a/xlators/debug/io-stats/src/Makefile.am +++ b/xlators/debug/io-stats/src/Makefile.am @@ -9,7 +9,7 @@ io_stats_la_LIBADD = $(top_builddir)/libglusterfs/src/libglusterfs.la noinst_HEADERS = io-stats-mem-types.h -AM_CFLAGS = -fPIC $(GF_CPPFLAGS) -Wall \ - -I$(top_srcdir)/libglusterfs/src -shared $(GF_CFLAGS) +AM_CFLAGS = $(GF_CPPFLAGS) -Wall \ + -I$(top_srcdir)/libglusterfs/src $(GF_CFLAGS) CLEANFILES = diff --git a/xlators/debug/trace/src/Makefile.am b/xlators/debug/trace/src/Makefile.am index b46174da2d7..d3016e09fa7 100644 --- a/xlators/debug/trace/src/Makefile.am +++ b/xlators/debug/trace/src/Makefile.am @@ -7,8 +7,8 @@ trace_la_LDFLAGS = -module -avoidversion trace_la_SOURCES = trace.c trace_la_LIBADD = $(top_builddir)/libglusterfs/src/libglusterfs.la -AM_CFLAGS = -fPIC $(GF_CPPFLAGS) -Wall \ - -I$(top_srcdir)/libglusterfs/src -shared $(GF_CFLAGS) +AM_CFLAGS = $(GF_CPPFLAGS) -Wall \ + -I$(top_srcdir)/libglusterfs/src $(GF_CFLAGS) CLEANFILES = |