diff options
| author | Prashanth Pai <ppai@redhat.com> | 2018-05-10 18:25:56 +0530 |
|---|---|---|
| committer | Amar Tumballi <amarts@redhat.com> | 2018-05-18 04:22:42 +0000 |
| commit | 89e1a4e5720509c096ff6860c1a8c483e0019278 (patch) | |
| tree | 88f1fabf37eff57db85c23822f305f4f16c4e280 /xlators/experimental/dht2 | |
| parent | c2cf3f686f3ea0efd936d2eafc404fc9d2e0acc7 (diff) | |
build: Disallow unresolved symbol references
In the past, it was often[1] forgotten for xlators to be linked against
the symbols they refer to. This often caused glusterd2 to fail while
loading xlator's shared object (.so) file.
This change adds "--no-undefined" as a linker flag which causes the
linker to treat unresolved symbol references as an error and hence fail
linking.
[1]:
https://review.gluster.org/#/c/19912/
https://review.gluster.org/#/c/19664/
https://review.gluster.org/#/c/19056/
https://review.gluster.org/#/c/17659/
https://bugzilla.redhat.com/show_bug.cgi?id=1532238
Bonus:
Added cloudsync and utime xlator's generated source files to .gitignore
Updates: bz#1193929
Change-Id: I9604a4a87b7313a5fa43bda5fdb37dfa7ef8facd
Signed-off-by: Prashanth Pai <ppai@redhat.com>
Diffstat (limited to 'xlators/experimental/dht2')
| -rw-r--r-- | xlators/experimental/dht2/dht2-client/src/Makefile.am | 2 | ||||
| -rw-r--r-- | xlators/experimental/dht2/dht2-server/src/Makefile.am | 2 |
2 files changed, 2 insertions, 2 deletions
diff --git a/xlators/experimental/dht2/dht2-client/src/Makefile.am b/xlators/experimental/dht2/dht2-client/src/Makefile.am index a16b9df2f76..3a13a2a3986 100644 --- a/xlators/experimental/dht2/dht2-client/src/Makefile.am +++ b/xlators/experimental/dht2/dht2-client/src/Makefile.am @@ -6,7 +6,7 @@ dht2c_sources = dht2-client-main.c dht2common_sources = $(top_srcdir)/xlators/experimental/dht2/dht2-common/src/dht2-common-map.c dht2c_la_SOURCES = $(dht2c_sources) $(dht2common_sources) -dht2c_la_LDFLAGS = -module -avoid-version +dht2c_la_LDFLAGS = -module $(GF_XLATOR_DEFAULT_LDFLAGS) dht2c_la_LIBADD = $(top_builddir)/libglusterfs/src/libglusterfs.la AM_CFLAGS = -Wall $(GF_CFLAGS) diff --git a/xlators/experimental/dht2/dht2-server/src/Makefile.am b/xlators/experimental/dht2/dht2-server/src/Makefile.am index 12d66d126f0..c76fab0ca74 100644 --- a/xlators/experimental/dht2/dht2-server/src/Makefile.am +++ b/xlators/experimental/dht2/dht2-server/src/Makefile.am @@ -8,7 +8,7 @@ dht2s_sources = dht2-server-main.c dht2common_sources = $(top_srcdir)/xlators/experimental/dht2/dht2-common/src/dht2-common-map.c dht2s_la_SOURCES = $(dht2s_sources) $(dht2common_sources) -dht2s_la_LDFLAGS = -module -avoid-version +dht2s_la_LDFLAGS = -module $(GF_XLATOR_DEFAULT_LDFLAGS) dht2s_la_LIBADD = $(top_builddir)/libglusterfs/src/libglusterfs.la AM_CFLAGS = -Wall $(GF_CFLAGS) |