diff options
| author | Jeff Darcy <jdarcy@redhat.com> | 2015-07-28 12:11:12 -0400 |
|---|---|---|
| committer | Jeff Darcy <jdarcy@redhat.com> | 2015-09-01 04:55:15 -0700 |
| commit | 0773ca67fdb60a142207759fa6c07a69882ce59c (patch) | |
| tree | 027101fce644fe17e58c78321b1632f38aaed166 /xlators/features/bit-rot/src/bitd/bit-rot-tbf.c | |
| parent | 038dfe57cf0c5944b0392332dbf5a00bb1208150 (diff) | |
all: reduce "inline" usage
There are three kinds of inline functions: plain inline, extern inline,
and static inline. All three have been removed from .c files, except
those in "contrib" which aren't our problem. Inlines in .h files, which
are overwhelmingly "static inline" already, have generally been left
alone. Over time we should be able to "lower" these into .c files, but
that has to be done in a case-by-case fashion requiring more manual
effort. This part was easy to do automatically without (as far as I can
tell) any ill effect.
In the process, several pieces of dead code were flagged by the
compiler, and were removed.
Change-Id: I56a5e614735c9e0a6ee420dab949eac22e25c155
BUG: 1245331
Signed-off-by: Jeff Darcy <jdarcy@redhat.com>
Reviewed-on: http://review.gluster.org/11769
Tested-by: NetBSD Build System <jenkins@build.gluster.org>
Reviewed-by: Dan Lambright <dlambrig@redhat.com>
Reviewed-by: Kaleb KEITHLEY <kkeithle@redhat.com>
Reviewed-by: Niels de Vos <ndevos@redhat.com>
Reviewed-by: Raghavendra Bhat <raghavendra@redhat.com>
Reviewed-by: Venky Shankar <vshankar@redhat.com>
Diffstat (limited to 'xlators/features/bit-rot/src/bitd/bit-rot-tbf.c')
| -rw-r--r-- | xlators/features/bit-rot/src/bitd/bit-rot-tbf.c | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/xlators/features/bit-rot/src/bitd/bit-rot-tbf.c b/xlators/features/bit-rot/src/bitd/bit-rot-tbf.c index d9543416540..f8b9b75d575 100644 --- a/xlators/features/bit-rot/src/bitd/bit-rot-tbf.c +++ b/xlators/features/bit-rot/src/bitd/bit-rot-tbf.c @@ -55,7 +55,7 @@ typedef struct br_tbf_throttle { */ #define BR_TBF_TOKENGEN_INTERVAL_USEC 600000 -static inline br_tbf_throttle_t * +static br_tbf_throttle_t * br_tbf_init_throttle (unsigned long tokens_required) { br_tbf_throttle_t *throttle = NULL; @@ -137,7 +137,7 @@ void *br_tbf_tokengenerator (void *arg) * under br_tbf_mod() context) and br_tbf_throttle(). *bucket is * updated _after_ all the required variables are initialized. */ -static inline int32_t +static int32_t br_tbf_init_bucket (br_tbf_t *tbf, br_tbf_opspec_t *spec) { int ret = 0; |