diff options
author | Raghavendra Bhat <raghavendra@redhat.com> | 2015-05-26 19:22:14 +0530 |
---|---|---|
committer | Venky Shankar <vshankar@redhat.com> | 2015-06-27 04:17:33 -0700 |
commit | 15dcfe98caa573e87d898cb66c13ef7187730c6b (patch) | |
tree | 0b4e523a9d34f71020200fb543e90ee248bcf7cf /xlators/features/bit-rot/src/bitd | |
parent | c2f577c1caea959caf6d3c4b00f7c68c34a26edb (diff) |
features/bit-rot-stub: deny access to bad objects
* Access to bad objects (especially operations such as open, readv, writev)
should be denied to prevent applications from getting wrong data.
* Do not allow anyone apart from scrubber to set bad object xattr.
* Do not allow bad object xattr to be removed.
Change-Id: Ia9185a067233a9f26e3d41d41d11d9a4eb0da827
BUG: 1210689
Signed-off-by: Raghavendra Bhat <raghavendra@redhat.com>
Signed-off-by: Venky Shankar <vshankar@redhat.com>
Signed-off-by: Raghavendra Bhat <raghavendra@redhat.com>
Reviewed-on: http://review.gluster.org/11126
Tested-by: NetBSD Build System <jenkins@build.gluster.org>
Diffstat (limited to 'xlators/features/bit-rot/src/bitd')
-rw-r--r-- | xlators/features/bit-rot/src/bitd/bit-rot.c | 7 |
1 files changed, 3 insertions, 4 deletions
diff --git a/xlators/features/bit-rot/src/bitd/bit-rot.c b/xlators/features/bit-rot/src/bitd/bit-rot.c index f58354a27c3..92ce0f405e5 100644 --- a/xlators/features/bit-rot/src/bitd/bit-rot.c +++ b/xlators/features/bit-rot/src/bitd/bit-rot.c @@ -159,11 +159,10 @@ bitd_is_bad_file (xlator_t *this, br_child_t *child, loc_t *loc, fd_t *fd) if (fd) ret = syncop_fgetxattr (child->xl, fd, &xattr, - "trusted.glusterfs.bad-file", NULL, - NULL); + BITROT_OBJECT_BAD_KEY, NULL, NULL); else if (loc) - ret = syncop_getxattr (child->xl, loc, &xattr, - "trusted.glusterfs.bad-file", NULL, + ret = syncop_getxattr (child->xl, loc, + &xattr, BITROT_OBJECT_BAD_KEY, NULL, NULL); if (!ret) { |