diff options
author | Jeff Darcy <jdarcy@redhat.com> | 2015-07-28 12:11:12 -0400 |
---|---|---|
committer | Jeff Darcy <jdarcy@redhat.com> | 2015-09-01 04:55:15 -0700 |
commit | 0773ca67fdb60a142207759fa6c07a69882ce59c (patch) | |
tree | 027101fce644fe17e58c78321b1632f38aaed166 /xlators/features/changetimerecorder/src | |
parent | 038dfe57cf0c5944b0392332dbf5a00bb1208150 (diff) |
all: reduce "inline" usage
There are three kinds of inline functions: plain inline, extern inline,
and static inline. All three have been removed from .c files, except
those in "contrib" which aren't our problem. Inlines in .h files, which
are overwhelmingly "static inline" already, have generally been left
alone. Over time we should be able to "lower" these into .c files, but
that has to be done in a case-by-case fashion requiring more manual
effort. This part was easy to do automatically without (as far as I can
tell) any ill effect.
In the process, several pieces of dead code were flagged by the
compiler, and were removed.
Change-Id: I56a5e614735c9e0a6ee420dab949eac22e25c155
BUG: 1245331
Signed-off-by: Jeff Darcy <jdarcy@redhat.com>
Reviewed-on: http://review.gluster.org/11769
Tested-by: NetBSD Build System <jenkins@build.gluster.org>
Reviewed-by: Dan Lambright <dlambrig@redhat.com>
Reviewed-by: Kaleb KEITHLEY <kkeithle@redhat.com>
Reviewed-by: Niels de Vos <ndevos@redhat.com>
Reviewed-by: Raghavendra Bhat <raghavendra@redhat.com>
Reviewed-by: Venky Shankar <vshankar@redhat.com>
Diffstat (limited to 'xlators/features/changetimerecorder/src')
-rw-r--r-- | xlators/features/changetimerecorder/src/changetimerecorder.c | 4 | ||||
-rw-r--r-- | xlators/features/changetimerecorder/src/ctr-xlator-ctx.c | 6 |
2 files changed, 5 insertions, 5 deletions
diff --git a/xlators/features/changetimerecorder/src/changetimerecorder.c b/xlators/features/changetimerecorder/src/changetimerecorder.c index 7fd62584752..5df9cb9097b 100644 --- a/xlators/features/changetimerecorder/src/changetimerecorder.c +++ b/xlators/features/changetimerecorder/src/changetimerecorder.c @@ -79,7 +79,7 @@ What is pending: /* This function doesnot write anything to the db, * just created the local variable * for the frame and sets values for the ctr_db_record */ -static inline int +static int ctr_lookup_wind(call_frame_t *frame, xlator_t *this, gf_ctr_inode_context_t *ctr_inode_cx) @@ -154,7 +154,7 @@ out: /* This function inserts the ctr_db_record populated by ctr_lookup_wind * in to the db. It also destroys the frame->local created by ctr_lookup_wind */ -static inline int +static int ctr_lookup_unwind (call_frame_t *frame, xlator_t *this) { diff --git a/xlators/features/changetimerecorder/src/ctr-xlator-ctx.c b/xlators/features/changetimerecorder/src/ctr-xlator-ctx.c index b5a54c0b5e4..c5900eac929 100644 --- a/xlators/features/changetimerecorder/src/ctr-xlator-ctx.c +++ b/xlators/features/changetimerecorder/src/ctr-xlator-ctx.c @@ -17,7 +17,7 @@ (ctr_hard_link->list.next == ctr_hard_link->list.prev) -static inline void +static void fini_ctr_hard_link (ctr_hard_link_t **ctr_hard_link) { GF_ASSERT (ctr_hard_link); @@ -246,7 +246,7 @@ out: /* Delete all hardlinks */ -static inline int +static int ctr_delete_all_hard_link (xlator_t *this, ctr_xlator_ctx_t *ctr_xlator_ctx) { @@ -277,7 +277,7 @@ ctr_delete_all_hard_link (xlator_t *this, /* Please lock the inode before using this function */ -static inline ctr_xlator_ctx_t * +static ctr_xlator_ctx_t * __get_ctr_xlator_ctx (xlator_t *this, inode_t *inode) { |