diff options
| author | Sunny Kumar <sunkumar@redhat.com> | 2018-10-09 19:40:31 +0530 |
|---|---|---|
| committer | Amar Tumballi <amarts@redhat.com> | 2018-10-10 08:00:26 +0000 |
| commit | 6472b43cfdb7454f1c1f1faf57ff13643d62fad7 (patch) | |
| tree | c667c22e55098188c1b7f5d86e2e31f963e20c37 /xlators/features/locks/src | |
| parent | 0f2113cb0c3f9dff028fb45a62ec2d1d82b4cb66 (diff) | |
locks : fix coverity issue
This patch fixes CID 1356544 and 1356539.
Both are of type NULL_RETURNS.
Change-Id: I2ef7c3ff9929c4d85b79fff00e835ebee3ff3ce0
updates: bz#789278
Signed-off-by: Sunny Kumar <sunkumar@redhat.com>
Diffstat (limited to 'xlators/features/locks/src')
| -rw-r--r-- | xlators/features/locks/src/common.c | 2 | ||||
| -rw-r--r-- | xlators/features/locks/src/posix.c | 6 |
2 files changed, 8 insertions, 0 deletions
diff --git a/xlators/features/locks/src/common.c b/xlators/features/locks/src/common.c index a953e0d1a4a..5ad5415ed79 100644 --- a/xlators/features/locks/src/common.c +++ b/xlators/features/locks/src/common.c @@ -363,6 +363,8 @@ pl_update_refkeeper(xlator_t *this, inode_t *inode) int need_ref = 0; pl_inode = pl_inode_get(this, inode); + if (!pl_inode) + return; pthread_mutex_lock(&pl_inode->mutex); { diff --git a/xlators/features/locks/src/posix.c b/xlators/features/locks/src/posix.c index 49ff36f0135..3528e686a96 100644 --- a/xlators/features/locks/src/posix.c +++ b/xlators/features/locks/src/posix.c @@ -1703,6 +1703,12 @@ pl_open(call_frame_t *frame, xlator_t *this, loc_t *loc, int32_t flags, op_ret = 0, op_errno = 0; pl_inode = pl_inode_get(this, fd->inode); + if (!pl_inode) { + gf_msg(this->name, GF_LOG_ERROR, 0, ENOMEM, "Could not get inode"); + op_ret = -1; + op_errno = ENOMEM; + goto unwind; + } /* As per design, under forced and file-based mandatory locking modes * it doesn't matter whether inodes's lock list contain advisory or |