diff options
| author | Ravishankar N <ravishankar@redhat.com> | 2016-03-03 23:17:17 +0530 |
|---|---|---|
| committer | Pranith Kumar Karampuri <pkarampu@redhat.com> | 2016-03-08 06:13:46 -0800 |
| commit | d1d364634dce0c3dcfe9c2efc883c21af0494d0d (patch) | |
| tree | 2af79ed651eb41643095b752844d4df9d169b02a /xlators/features/locks/src | |
| parent | eea4175addff08d010c2f7c6446397561b1cd919 (diff) | |
afr: misc performance improvements
1. In afr_getxattr_cbk, consider the errno value before blindly
launching an inode refresh and a subsequent retry on other children.
2. We want to accuse small files only when we know for sure that there is no
IO happening on that inode. Otherwise, the ia_sizes obtained in the
post-inode-refresh replies may mismatch due to a race between
inode-refresh and ongoing writes, causing spurious heal launches.
Change-Id: Ife180f4fa5e584808c1077aacdc2423897675d33
BUG: 1309462
Signed-off-by: Ravishankar N <ravishankar@redhat.com>
Reviewed-on: http://review.gluster.org/13595
Smoke: Gluster Build System <jenkins@build.gluster.com>
Tested-by: Pranith Kumar Karampuri <pkarampu@redhat.com>
NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
CentOS-regression: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Krutika Dhananjay <kdhananj@redhat.com>
Reviewed-by: Pranith Kumar Karampuri <pkarampu@redhat.com>
Diffstat (limited to 'xlators/features/locks/src')
| -rw-r--r-- | xlators/features/locks/src/posix.c | 18 |
1 files changed, 18 insertions, 0 deletions
diff --git a/xlators/features/locks/src/posix.c b/xlators/features/locks/src/posix.c index dae881d4f20..eedd2746816 100644 --- a/xlators/features/locks/src/posix.c +++ b/xlators/features/locks/src/posix.c @@ -2184,6 +2184,23 @@ pl_lookup (call_frame_t *frame, xlator_t *this, loc_t *loc, dict_t *xdata) return 0; } +int32_t +pl_fstat_cbk (call_frame_t *frame, void *cookie, xlator_t *this, int32_t op_ret, + int32_t op_errno, struct iatt *buf, dict_t *xdata) +{ + PL_STACK_UNWIND (fstat, xdata, frame, op_ret, op_errno, buf, xdata); + return 0; +} + +int32_t +pl_fstat (call_frame_t *frame, xlator_t *this, fd_t *fd, dict_t *xdata) +{ + PL_LOCAL_GET_REQUESTS (frame, this, xdata, fd, NULL); + STACK_WIND (frame, pl_fstat_cbk, FIRST_CHILD(this), + FIRST_CHILD(this)->fops->fstat, fd, xdata); + return 0; +} + int pl_readdirp_cbk (call_frame_t *frame, void *cookie, xlator_t *this, int op_ret, int op_errno, gf_dirent_t *entries, dict_t *xdata) @@ -2771,6 +2788,7 @@ pl_fentrylk (call_frame_t *frame, xlator_t *this, struct xlator_fops fops = { .lookup = pl_lookup, .create = pl_create, + .fstat = pl_fstat, .truncate = pl_truncate, .ftruncate = pl_ftruncate, .open = pl_open, |