Eliminate many "var set but not used" warnings with newer gcc.

This fixes ~200 such warnings, but leaves three categories untouched.

(1) Rpcgen code.

(2) Macros which set variables in the outer (calling function) scope.

(3) Variables which are set via function calls which may have side effects.

Change-Id: I6554555f78ed26134251504b038da7e94adacbcd
BUG: 2550
Reviewed-on: http://review.gluster.com/371
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Anand Avati <avati@gluster.com>

1 files changed, 0 insertions, 57 deletions

diff --git a/xlators/features/quiesce/src/quiesce.c b/xlators/features/quiesce/src/quiesce.c
index 7fd16ceb961..84df12a31ff 100644
--- a/xlators/features/quiesce/src/quiesce.c
+++ b/xlators/features/quiesce/src/quiesce.c
@@ -34,13 +34,9 @@
 void
 gf_quiesce_local_wipe (xlator_t *this, quiesce_local_t *local)
 {
-        quiesce_priv_t  *priv  = NULL;
-
         if (!local || !this || !this->private)
                 return;
 
-        priv  = this->private;
-
         if (local->loc.inode)
                 loc_wipe (&local->loc);
         if (local->fd)
@@ -108,7 +104,6 @@ gf_quiesce_timeout (void *data)
 {
         xlator_t       *this = NULL;
         quiesce_priv_t *priv = NULL;
-        int             need_dequeue = 0;
 
         this = data;
         priv = this->private;
@@ -117,7 +112,6 @@ gf_quiesce_timeout (void *data)
         LOCK (&priv->lock);
         {
                 priv->pass_through = _gf_true;
-                need_dequeue = (priv->queue_size)? 1:0;
         }
         UNLOCK (&priv->lock);
 
@@ -168,12 +162,9 @@ quiesce_lookup_cbk (call_frame_t *frame, void *cookie, xlator_t *this,
                     int32_t op_ret, int32_t op_errno, inode_t *inode,
                     struct iatt *buf, dict_t *dict, struct iatt *postparent)
 {
-        quiesce_priv_t *priv = NULL;
         call_stub_t    *stub = NULL;
         quiesce_local_t *local = NULL;
 
-        priv = this->private;
-
         local = frame->local;
         frame->local = NULL;
         if ((op_ret == -1) && (op_errno == ENOTCONN)) {
@@ -202,12 +193,9 @@ int32_t
 quiesce_stat_cbk (call_frame_t *frame, void *cookie, xlator_t *this,
                   int32_t op_ret, int32_t op_errno, struct iatt *buf)
 {
-        quiesce_priv_t *priv = NULL;
         call_stub_t    *stub = NULL;
         quiesce_local_t *local = NULL;
 
-        priv = this->private;
-
         local = frame->local;
         frame->local = NULL;
         if ((op_ret == -1) && (op_errno == ENOTCONN)) {
@@ -235,12 +223,9 @@ int32_t
 quiesce_access_cbk (call_frame_t *frame, void *cookie, xlator_t *this,
                     int32_t op_ret, int32_t op_errno)
 {
-        quiesce_priv_t *priv = NULL;
         call_stub_t    *stub = NULL;
         quiesce_local_t *local = NULL;
 
-        priv = this->private;
-
         local = frame->local;
         frame->local = NULL;
         if ((op_ret == -1) && (op_errno == ENOTCONN)) {
@@ -268,12 +253,9 @@ quiesce_readlink_cbk (call_frame_t *frame, void *cookie, xlator_t *this,
                       int32_t op_ret, int32_t op_errno, const char *path,
                       struct iatt *buf)
 {
-        quiesce_priv_t *priv = NULL;
         call_stub_t    *stub = NULL;
         quiesce_local_t *local = NULL;
 
-        priv = this->private;
-
         local = frame->local;
         frame->local = NULL;
         if ((op_ret == -1) && (op_errno == ENOTCONN)) {
@@ -301,12 +283,9 @@ int32_t
 quiesce_open_cbk (call_frame_t *frame, void *cookie, xlator_t *this,
                   int32_t op_ret, int32_t op_errno, fd_t *fd)
 {
-        quiesce_priv_t *priv = NULL;
         call_stub_t    *stub = NULL;
         quiesce_local_t *local = NULL;
 
-        priv = this->private;
-
         local = frame->local;
         frame->local = NULL;
         if ((op_ret == -1) && (op_errno == ENOTCONN)) {
@@ -336,12 +315,9 @@ quiesce_readv_cbk (call_frame_t *frame, void *cookie, xlator_t *this,
                    int32_t op_ret, int32_t op_errno, struct iovec *vector,
                    int32_t count, struct iatt *stbuf, struct iobref *iobref)
 {
-        quiesce_priv_t *priv = NULL;
         call_stub_t    *stub = NULL;
         quiesce_local_t *local = NULL;
 
-        priv = this->private;
-
         local = frame->local;
         frame->local = NULL;
         if ((op_ret == -1) && (op_errno == ENOTCONN)) {
@@ -370,12 +346,9 @@ int32_t
 quiesce_flush_cbk (call_frame_t *frame, void *cookie, xlator_t *this,
                    int32_t op_ret, int32_t op_errno)
 {
-        quiesce_priv_t *priv = NULL;
         call_stub_t    *stub = NULL;
         quiesce_local_t *local = NULL;
 
-        priv = this->private;
-
         local = frame->local;
         frame->local = NULL;
         if ((op_ret == -1) && (op_errno == ENOTCONN)) {
@@ -405,12 +378,9 @@ quiesce_fsync_cbk (call_frame_t *frame, void *cookie, xlator_t *this,
                    int32_t op_ret, int32_t op_errno, struct iatt *prebuf,
                    struct iatt *postbuf)
 {
-        quiesce_priv_t *priv = NULL;
         call_stub_t    *stub = NULL;
         quiesce_local_t *local = NULL;
 
-        priv = this->private;
-
         local = frame->local;
         frame->local = NULL;
         if ((op_ret == -1) && (op_errno == ENOTCONN)) {
@@ -438,12 +408,9 @@ int32_t
 quiesce_fstat_cbk (call_frame_t *frame, void *cookie, xlator_t *this,
                    int32_t op_ret, int32_t op_errno, struct iatt *buf)
 {
-        quiesce_priv_t *priv = NULL;
         call_stub_t    *stub = NULL;
         quiesce_local_t *local = NULL;
 
-        priv = this->private;
-
         local = frame->local;
         frame->local = NULL;
         if ((op_ret == -1) && (op_errno == ENOTCONN)) {
@@ -471,12 +438,9 @@ int32_t
 quiesce_opendir_cbk (call_frame_t *frame, void *cookie, xlator_t *this,
                      int32_t op_ret, int32_t op_errno, fd_t *fd)
 {
-        quiesce_priv_t *priv = NULL;
         call_stub_t    *stub = NULL;
         quiesce_local_t *local = NULL;
 
-        priv = this->private;
-
         local = frame->local;
         frame->local = NULL;
         if ((op_ret == -1) && (op_errno == ENOTCONN)) {
@@ -504,12 +468,9 @@ int32_t
 quiesce_fsyncdir_cbk (call_frame_t *frame, void *cookie, xlator_t *this,
                       int32_t op_ret, int32_t op_errno)
 {
-        quiesce_priv_t *priv = NULL;
         call_stub_t    *stub = NULL;
         quiesce_local_t *local = NULL;
 
-        priv = this->private;
-
         local = frame->local;
         frame->local = NULL;
         if ((op_ret == -1) && (op_errno == ENOTCONN)) {
@@ -536,12 +497,9 @@ int32_t
 quiesce_statfs_cbk (call_frame_t *frame, void *cookie, xlator_t *this,
                     int32_t op_ret, int32_t op_errno, struct statvfs *buf)
 {
-        quiesce_priv_t *priv = NULL;
         call_stub_t    *stub = NULL;
         quiesce_local_t *local = NULL;
 
-        priv = this->private;
-
         local = frame->local;
         frame->local = NULL;
         if ((op_ret == -1) && (op_errno == ENOTCONN)) {
@@ -569,12 +527,9 @@ int32_t
 quiesce_fgetxattr_cbk (call_frame_t *frame, void *cookie, xlator_t *this,
                        int32_t op_ret, int32_t op_errno, dict_t *dict)
 {
-        quiesce_priv_t *priv = NULL;
         call_stub_t    *stub = NULL;
         quiesce_local_t *local = NULL;
 
-        priv = this->private;
-
         local = frame->local;
         frame->local = NULL;
         if ((op_ret == -1) && (op_errno == ENOTCONN)) {
@@ -603,12 +558,9 @@ int32_t
 quiesce_getxattr_cbk (call_frame_t *frame, void *cookie, xlator_t *this,
                       int32_t op_ret, int32_t op_errno, dict_t *dict)
 {
-        quiesce_priv_t *priv = NULL;
         call_stub_t    *stub = NULL;
         quiesce_local_t *local = NULL;
 
-        priv = this->private;
-
         local = frame->local;
         frame->local = NULL;
         if ((op_ret == -1) && (op_errno == ENOTCONN)) {
@@ -638,12 +590,9 @@ quiesce_rchecksum_cbk (call_frame_t *frame, void *cookie, xlator_t *this,
                        int32_t op_ret, int32_t op_errno, uint32_t weak_checksum,
                        uint8_t *strong_checksum)
 {
-        quiesce_priv_t *priv = NULL;
         call_stub_t    *stub = NULL;
         quiesce_local_t *local = NULL;
 
-        priv = this->private;
-
         local = frame->local;
         frame->local = NULL;
         if ((op_ret == -1) && (op_errno == ENOTCONN)) {
@@ -673,12 +622,9 @@ int32_t
 quiesce_readdir_cbk (call_frame_t *frame, void *cookie, xlator_t *this,
                      int32_t op_ret, int32_t op_errno, gf_dirent_t *entries)
 {
-        quiesce_priv_t *priv = NULL;
         call_stub_t    *stub = NULL;
         quiesce_local_t *local = NULL;
 
-        priv = this->private;
-
         local = frame->local;
         frame->local = NULL;
         if ((op_ret == -1) && (op_errno == ENOTCONN)) {
@@ -707,12 +653,9 @@ int32_t
 quiesce_readdirp_cbk (call_frame_t *frame, void *cookie, xlator_t *this,
                       int32_t op_ret, int32_t op_errno, gf_dirent_t *entries)
 {
-        quiesce_priv_t *priv = NULL;
         call_stub_t    *stub = NULL;
         quiesce_local_t *local = NULL;
 
-        priv = this->private;
-
         local = frame->local;
         frame->local = NULL;
         if ((op_ret == -1) && (op_errno == ENOTCONN)) {