diff options
| author | Kinglong Mee <kinglongmee@gmail.com> | 2019-01-18 10:38:14 +0800 |
|---|---|---|
| committer | Amar Tumballi <amarts@redhat.com> | 2019-01-21 03:11:20 +0000 |
| commit | c5bb929b367121f2610f74630882254da7fd882a (patch) | |
| tree | d6e9a697eb50eaee576ad48df1f9ddf719265938 /xlators/features/quota/src/quotad.c | |
| parent | 0687b0beb5cc58d5aac9e203f0feebcd7e9eea03 (diff) | |
quotad: fix wrong memory free
1. cli_req.dict.dict_val,
It must be freed no metter operation error or success.
Fix it as lookup "alloca" memory before decode.
2. args.xdata.xdata_val,
It is allocated by "alloca", free is unneeded.
3. qd_nameless_lookup,
It olny needs gfid, a gfs3_lookup_req argument is unneeded.
Change-Id: I746dddf7f3d1465b1885af2644afe0bcf0a5665b
fixes: bz#1656682
Signed-off-by: Kinglong Mee <mijinlong@open-fs.com>
Diffstat (limited to 'xlators/features/quota/src/quotad.c')
| -rw-r--r-- | xlators/features/quota/src/quotad.c | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/xlators/features/quota/src/quotad.c b/xlators/features/quota/src/quotad.c index ee1a600e60f..11ef2b1189c 100644 --- a/xlators/features/quota/src/quotad.c +++ b/xlators/features/quota/src/quotad.c @@ -104,7 +104,7 @@ out: } int -qd_nameless_lookup(xlator_t *this, call_frame_t *frame, gfs3_lookup_req *req, +qd_nameless_lookup(xlator_t *this, call_frame_t *frame, char *gfid, dict_t *xdata, quotad_aggregator_lookup_cbk_t lookup_cbk) { gfs3_lookup_rsp rsp = { @@ -128,7 +128,7 @@ qd_nameless_lookup(xlator_t *this, call_frame_t *frame, gfs3_lookup_req *req, goto out; } - memcpy(loc.gfid, req->gfid, 16); + memcpy(loc.gfid, gfid, 16); ret = dict_get_strn(xdata, "volume-uuid", SLEN("volume-uuid"), &volume_uuid); |