diff options
| author | Kaleb S. KEITHLEY <kkeithle@redhat.com> | 2015-07-31 14:11:15 -0400 |
|---|---|---|
| committer | Niels de Vos <ndevos@redhat.com> | 2015-09-24 07:37:42 -0700 |
| commit | 1d82db506d1cd5b20d14820d89033de2e4a14210 (patch) | |
| tree | b4bc67f988b054d5e738884a91ce18c48244161a /xlators/features/read-only | |
| parent | 84367f0c9106f5a604ac05a02898d4521fa5c832 (diff) | |
build: export minimum symbols from xlators for correct resolution
We've been lucky that we haven't had any symbol collisions until now.
Now we have a collision between the snapview-client's svc_lookup() and
libntirpc's svc_lookup() with nfs-ganesha's FSAL_GLUSTER and libgfapi.
As a short term solution all the snapview-client's FOP methods were
changed to static scope. See http://review.gluster.org/11805. This
works in snapview-client because all the FOP methods are defined in
a single source file. This solution doesn't work for other xlators
with FOP methods defined in multiple source files.
To address this we link with libtool's '-export-symbols $symbol-file'
(a wrapper around `ld --version-script ...` --- on linux anyway) and
only export the minimum required symbols from the xlator sharedlib.
N.B. the libtool man page says that the symbol file should be named
foo.sym, thus the rename of *.exports to *.sym. While foo.exports
worked, we will follow the documentation.
Signed-off-by: Kaleb S. KEITHLEY <kkeithle@redhat.com>
BUG: 1248669
Change-Id: I1de68b3e3be58ae690d8bfb2168bfc019983627c
Reviewed-on: http://review.gluster.org/11814
Tested-by: NetBSD Build System <jenkins@build.gluster.org>
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: soumya k <skoduri@redhat.com>
Reviewed-by: Niels de Vos <ndevos@redhat.com>
Diffstat (limited to 'xlators/features/read-only')
| -rw-r--r-- | xlators/features/read-only/src/Makefile.am | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/xlators/features/read-only/src/Makefile.am b/xlators/features/read-only/src/Makefile.am index 209e4208af0..a44fd36f035 100644 --- a/xlators/features/read-only/src/Makefile.am +++ b/xlators/features/read-only/src/Makefile.am @@ -4,12 +4,12 @@ xlatordir = $(libdir)/glusterfs/$(PACKAGE_VERSION)/xlator/features noinst_HEADERS = read-only.h read-only-mem-types.h read-only-common.h -read_only_la_LDFLAGS = -module -avoid-version +read_only_la_LDFLAGS = $(GF_XLATOR_DEFAULT_LDFLAGS) read_only_la_SOURCES = read-only.c read-only-common.c read_only_la_LIBADD = $(top_builddir)/libglusterfs/src/libglusterfs.la -worm_la_LDFLAGS = -module -avoid-version +worm_la_LDFLAGS = $(GF_XLATOR_DEFAULT_LDFLAGS) worm_la_SOURCES = read-only-common.c worm.c worm_la_LIBADD = $(top_builddir)/libglusterfs/src/libglusterfs.la |