diff options
author | Poornima G <pgurusid@redhat.com> | 2016-07-11 15:04:55 +0530 |
---|---|---|
committer | Raghavendra G <rgowdapp@redhat.com> | 2016-08-30 23:07:01 -0700 |
commit | 8f053f9d7270f1c6d50c0b3ab5d020503ceeb31a (patch) | |
tree | 754b2dbc815e8b0d619016b5d53f7e0acfae8c40 /xlators/features/upcall/src/upcall.h | |
parent | 55c255b27a99f027cb716800f8330f8faa4eb1f5 (diff) |
md-cache: Register the list of xattrs with cache-invalidation
Issue:
md-cache caches a specified list of xattrs, and when cache invalidation
is enabled, it makes sense to recieve invalidation only when those xattrs
are modified by other clients. But the current implementation of upcall
is that, it will send invalidation when any of the on-disk xattrs is modified.
Solution:
md-cache sends a list of xattrs that it is interested in, to upcall by
issuing an ipc(). The challenge here is to make sure everytime a brick
goes offline and comes back up, the ipc() needs to be issued to the
bricks. Hence ipc() is sent from md-cache every time there is a
CHILD_UP/CHILD_MODIFIED event.
TODO:
There will be patches following, in cluster xlators, to implement ipc fop.
Change-Id: I6efcf3df474f5ce6eabd3d6694c00c7bd89bc25d
BUG: 1211863
Signed-off-by: Poornima G <pgurusid@redhat.com>
Reviewed-on: http://review.gluster.org/15002
Smoke: Gluster Build System <jenkins@build.gluster.org>
CentOS-regression: Gluster Build System <jenkins@build.gluster.org>
Reviewed-by: Rajesh Joseph <rjoseph@redhat.com>
NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
Reviewed-by: Prashanth Pai <ppai@redhat.com>
Reviewed-by: Raghavendra G <rgowdapp@redhat.com>
Diffstat (limited to 'xlators/features/upcall/src/upcall.h')
-rw-r--r-- | xlators/features/upcall/src/upcall.h | 6 |
1 files changed, 4 insertions, 2 deletions
diff --git a/xlators/features/upcall/src/upcall.h b/xlators/features/upcall/src/upcall.h index f86849341ec..852f5511726 100644 --- a/xlators/features/upcall/src/upcall.h +++ b/xlators/features/upcall/src/upcall.h @@ -52,6 +52,8 @@ struct _upcall_private_t { gf_boolean_t reaper_init_done; pthread_t reaper_thr; int32_t fini; + dict_t *xattrs; /* list of xattrs registered by clients + for receiving invalidation */ }; typedef struct _upcall_private_t upcall_private_t; @@ -130,6 +132,6 @@ void upcall_client_cache_invalidate (xlator_t *xl, uuid_t gfid, struct iatt *p_stbuf, struct iatt *oldp_stbuf, dict_t *xattr); -int up_filter_virtual_xattr (dict_t *d, char *k, data_t *v, void *tmp); - +int up_filter_unregd_xattr (dict_t *xattrs, char *xattr, data_t *v, + void *regd_xattrs); #endif /* __UPCALL_H__ */ |