diff options
| author | Niels de Vos <ndevos@redhat.com> | 2015-05-18 16:26:02 +0200 |
|---|---|---|
| committer | Pranith Kumar Karampuri <pkarampu@redhat.com> | 2015-05-29 05:43:17 -0700 |
| commit | 8a9328e37b8c63d60583184dc8dab12f85810682 (patch) | |
| tree | 0fa017379bf5e9dfaa2e6d8132c73cc1090a3d52 /xlators/features/upcall | |
| parent | 5d912230a7d4f9979c10ff15da724624bd8e069d (diff) | |
build: do not #include "config.h" in each file
Instead of including config.h in each file, and have the additional
config.h included from the compiler commandline (-include option).
When a .c file tests for a certain #define, and config.h was not
included, incorrect assumtions were made. With this change, it can not
happen again.
BUG: 1222319
Change-Id: I4f9097b8740b81ecfe8b218d52ca50361f74cb64
Signed-off-by: Niels de Vos <ndevos@redhat.com>
Reviewed-on: http://review.gluster.org/10808
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Tested-by: NetBSD Build System
Reviewed-by: Kaleb KEITHLEY <kkeithle@redhat.com>
Reviewed-by: Pranith Kumar Karampuri <pkarampu@redhat.com>
Diffstat (limited to 'xlators/features/upcall')
| -rw-r--r-- | xlators/features/upcall/src/upcall-cache-invalidation.h | 5 | ||||
| -rw-r--r-- | xlators/features/upcall/src/upcall-internal.c | 5 | ||||
| -rw-r--r-- | xlators/features/upcall/src/upcall-messages.h | 5 | ||||
| -rw-r--r-- | xlators/features/upcall/src/upcall.c | 5 | ||||
| -rw-r--r-- | xlators/features/upcall/src/upcall.h | 5 |
5 files changed, 0 insertions, 25 deletions
diff --git a/xlators/features/upcall/src/upcall-cache-invalidation.h b/xlators/features/upcall/src/upcall-cache-invalidation.h index edb8285827f..77286b063d8 100644 --- a/xlators/features/upcall/src/upcall-cache-invalidation.h +++ b/xlators/features/upcall/src/upcall-cache-invalidation.h @@ -11,11 +11,6 @@ #ifndef __UPCALL_CACHE_INVALIDATION_H__ #define __UPCALL_CACHE_INVALIDATION_H__ -#ifndef _CONFIG_H -#define _CONFIG_H -#include "config.h" -#endif - /* The time period for which a client will be notified of cache_invalidation * events post its last access */ #define CACHE_INVALIDATION_TIMEOUT "60" diff --git a/xlators/features/upcall/src/upcall-internal.c b/xlators/features/upcall/src/upcall-internal.c index b128ab3bdc9..f618e2655fc 100644 --- a/xlators/features/upcall/src/upcall-internal.c +++ b/xlators/features/upcall/src/upcall-internal.c @@ -12,11 +12,6 @@ #include <fcntl.h> #include <limits.h> -#ifndef _CONFIG_H -#define _CONFIG_H -#include "config.h" -#endif - #include "glusterfs.h" #include "compat.h" #include "xlator.h" diff --git a/xlators/features/upcall/src/upcall-messages.h b/xlators/features/upcall/src/upcall-messages.h index 5472b4a5cbd..0cfdfd68b77 100644 --- a/xlators/features/upcall/src/upcall-messages.h +++ b/xlators/features/upcall/src/upcall-messages.h @@ -11,11 +11,6 @@ #ifndef _UPCALL_MESSAGES_H_ #define _UPCALL_MESSAGES_H_ -#ifndef _CONFIG_H -#define _CONFIG_H -#include "config.h" -#endif - #include "glfs-message-id.h" /*! \file upcall-messages.h diff --git a/xlators/features/upcall/src/upcall.c b/xlators/features/upcall/src/upcall.c index 5f6c29e1b79..50e621a1127 100644 --- a/xlators/features/upcall/src/upcall.c +++ b/xlators/features/upcall/src/upcall.c @@ -13,11 +13,6 @@ #include <limits.h> #include <pthread.h> -#ifndef _CONFIG_H -#define _CONFIG_H -#include "config.h" -#endif - #include "glusterfs.h" #include "compat.h" #include "xlator.h" diff --git a/xlators/features/upcall/src/upcall.h b/xlators/features/upcall/src/upcall.h index 295ddc26167..eb1c7df89be 100644 --- a/xlators/features/upcall/src/upcall.h +++ b/xlators/features/upcall/src/upcall.h @@ -10,11 +10,6 @@ #ifndef __UPCALL_H__ #define __UPCALL_H__ -#ifndef _CONFIG_H -#define _CONFIG_H -#include "config.h" -#endif - #include "compat-errno.h" #include "upcall-mem-types.h" #include "client_t.h" |