diff options
| author | Atin Mukherjee <amukherj@redhat.com> | 2014-10-27 12:12:03 +0530 |
|---|---|---|
| committer | Kaushal M <kaushal@redhat.com> | 2014-11-06 03:03:55 -0800 |
| commit | 97ccd45fb66a63c0b2436a0245dfb9490e2941b7 (patch) | |
| tree | d5827a165c502f267156f0e3d28cb10d93f7faee /xlators/mgmt/glusterd/src/glusterd-messages.h | |
| parent | 1a735e300a0ecd35d41f68f3c776350bb18f763a (diff) | |
glusterd : release cluster wide locks in op-sm during failures
glusterd op-sm infrastructure has some loophole in handing error cases in
locking/unlocking phases which ends up having stale locks restricting
further transactions to go through.
This patch still doesn't handle all possible unlocking error cases as the
framework neither has retry mechanism nor the lock timeout. For eg - if
unlocking fails in one of the peer, cluster wide lock is not released and
further transaction can not be made until and unless originator node/the node
where unlocking failed is restarted.
Following test cases were executed (with the help of gdb) after applying this
patch:
* RPC timesout in lock cbk
* Decoding of RPC response in lock cbk fails
* RPC response is received from unknown peer in lock cbk
* Setting peerinfo in dictionary fails while sending lock request for first peer
in the list
* Setting peerinfo in dictionary fails while sending lock request for other
peers
* Lock RPC could not be sent for peers
For all above test cases the success criteria is not to have any stale locks
Change-Id: Ia1550341c31005c7850ee1b2697161c9ca04b01a
BUG: 1154635
Signed-off-by: Atin Mukherjee <amukherj@redhat.com>
Reviewed-on: http://review.gluster.org/9012
Reviewed-by: Krishnan Parthasarathi <kparthas@redhat.com>
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Kaushal M <kaushal@redhat.com>
Diffstat (limited to 'xlators/mgmt/glusterd/src/glusterd-messages.h')
| -rw-r--r-- | xlators/mgmt/glusterd/src/glusterd-messages.h | 11 |
1 files changed, 10 insertions, 1 deletions
diff --git a/xlators/mgmt/glusterd/src/glusterd-messages.h b/xlators/mgmt/glusterd/src/glusterd-messages.h index 604743ef5e7..b4f8585097a 100644 --- a/xlators/mgmt/glusterd/src/glusterd-messages.h +++ b/xlators/mgmt/glusterd/src/glusterd-messages.h @@ -45,7 +45,7 @@ */ #define GLUSTERD_COMP_BASE GLFS_MSGID_GLUSTERD -#define GLFS_NUM_MESSAGES 19 +#define GLFS_NUM_MESSAGES 20 #define GLFS_MSGID_END (GLUSTERD_COMP_BASE + GLFS_NUM_MESSAGES + 1) /* Messaged with message IDs */ #define glfs_msg_start_x GLFS_COMP_BASE, "Invalid: Start of messages" @@ -206,6 +206,15 @@ * failure to set default options */ #define GD_MSG_FAIL_DEFAULT_OPT_SET (GLUSTERD_COMP_BASE + 19) + +/*! + * @messageid 106020 + * @diagnosis Failed to release cluster wide lock for one of the peer + * @recommendedaction Restart the glusterd service on the node where the command + * was issued + */ +#define GD_MSG_CLUSTER_UNLOCK_FAILED (GLUSTERD_COMP_BASE + 20) + /*------------*/ #define glfs_msg_end_x GLFS_MSGID_END, "Invalid: End of messages" |