tier : Tier as a service

tierd is implemented by separating from rebalance process.

The commands affected:

1) Attach tier will trigger this process instead of old one
2) tier start and tier start force will also trigger this process.
3) volume status [tier] will show tier daemon as a process instead
of task and normal tier status and tier detach status works.
4) tier stop implemented.
5) detach tier implemented separately along with new detach tier
status
6) volume tier volname status will work using the changes.
7) volume set works

This patch has separated the tier translator from the legacy
DHT rebalance code. It now sends the RPCs from the CLI
to glusterd separate to the DHT rebalance code.
The daemon is now a service, similar to the snapshot daemon,
and can be viewed using the volume status command.

The code for the validation and commit phase are the same
as the earlier tier validation code in DHT rebalance.

The “brickop” phase has been changed so that the status
command can use this framework.

The service management framework is now used.
DHT rebalance does not use this framework.

This service framework takes care of :

*) spawning the daemon, killing it and other such processes.
*) volume set options , which are written on the volfile.
*) restart and reconfigure functions. Restart is to restart
the daemon at two points
        1)after gluster goes down and comes up.
        2) to stop detach tier.
*) reconfigure is used to make immediate volfile changes.
By doing this, we don’t restart the daemon.
it has the code to rewrite the volfile for topological
changes too (which comes into place during add and remove brick).

With this patch the log, pid, and volfile are separated
and put into respective directories.

Change-Id: I3681d0d66894714b55aa02ca2a30ac000362a399
BUG: 1313838
Signed-off-by: hari gowtham <hgowtham@redhat.com>
Reviewed-on: http://review.gluster.org/13365
Smoke: Gluster Build System <jenkins@build.gluster.org>
Tested-by: hari gowtham <hari.gowtham005@gmail.com>
CentOS-regression: Gluster Build System <jenkins@build.gluster.org>
NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
Reviewed-by: Dan Lambright <dlambrig@redhat.com>
Reviewed-by: Atin Mukherjee <amukherj@redhat.com>

1 files changed, 100 insertions, 10 deletions

diff --git a/xlators/mgmt/glusterd/src/glusterd-mgmt.c b/xlators/mgmt/glusterd/src/glusterd-mgmt.c
index b7b1a3fcbfd..7a7db069b6e 100644
--- a/xlators/mgmt/glusterd/src/glusterd-mgmt.c
+++ b/xlators/mgmt/glusterd/src/glusterd-mgmt.c
@@ -188,6 +188,18 @@ gd_mgmt_v3_pre_validate_fn (glusterd_op_t op, dict_t *dict,
                         goto out;
                 }
                 break;
+        case GD_OP_TIER_START_STOP:
+        case GD_OP_TIER_STATUS:
+        case GD_OP_DETACH_TIER_STATUS:
+        case GD_OP_REMOVE_TIER_BRICK:
+                ret = glusterd_op_stage_tier (dict, op_errstr, rsp_dict);
+                if (ret) {
+                        gf_msg (this->name, GF_LOG_ERROR, 0,
+                                GD_MSG_COMMAND_NOT_FOUND, "tier "
+                                "prevalidation failed");
+                        goto out;
+                }
+                break;
 
         case GD_OP_RESET_BRICK:
                ret = glusterd_reset_brick_prevalidate (dict, op_errstr,
@@ -256,6 +268,7 @@ gd_mgmt_v3_commit_fn (glusterd_op_t op, dict_t *dict,
 {
         int32_t       ret = -1;
         xlator_t     *this = NULL;
+        int32_t       cmd  = 0;
 
         this = THIS;
         GF_ASSERT (this);
@@ -336,6 +349,49 @@ gd_mgmt_v3_commit_fn (glusterd_op_t op, dict_t *dict,
                         }
                         break;
                 }
+                case GD_OP_TIER_START_STOP:
+                {
+                        ret = glusterd_op_tier_start_stop (dict, op_errstr,
+                                                           rsp_dict);
+                        if (ret) {
+                                gf_msg (this->name, GF_LOG_ERROR, 0,
+                                        GD_MSG_COMMIT_OP_FAIL,
+                                        "tier commit failed.");
+                                goto out;
+                        }
+                        break;
+                }
+                case GD_OP_REMOVE_TIER_BRICK:
+                {
+                        ret = glusterd_op_remove_tier_brick (dict, op_errstr,
+                                                       rsp_dict);
+                        if (ret) {
+                                gf_msg (this->name, GF_LOG_ERROR, 0,
+                                        GD_MSG_COMMIT_OP_FAIL,
+                                        "tier detach commit failed.");
+                                goto out;
+                        }
+                        ret = dict_get_int32 (dict, "rebalance-command", &cmd);
+                        if (ret) {
+                                gf_msg_debug (this->name, 0, "cmd not found");
+                                goto out;
+                        }
+
+                        if (cmd != GF_DEFRAG_CMD_DETACH_STOP)
+                                break;
+                }
+                case GD_OP_DETACH_TIER_STATUS:
+                case GD_OP_TIER_STATUS:
+                {
+                        ret = glusterd_op_tier_status (dict, op_errstr,
+                                                       rsp_dict, op);
+                        if (ret) {
+                                gf_msg (this->name, GF_LOG_WARNING, 0,
+                                        GD_MSG_COMMIT_OP_FAIL,
+                                        "tier status commit failed");
+                                goto out;
+                        }
+                }
 
                default:
                        break;
@@ -355,6 +411,7 @@ gd_mgmt_v3_post_validate_fn (glusterd_op_t op, int32_t op_ret, dict_t *dict,
         xlator_t                *this      = NULL;
         char                    *volname   = NULL;
         glusterd_volinfo_t      *volinfo   = NULL;
+        glusterd_svc_t          *svc       = NULL;
 
 
         this = THIS;
@@ -427,13 +484,11 @@ gd_mgmt_v3_post_validate_fn (glusterd_op_t op, int32_t op_ret, dict_t *dict,
                         }
 
                         if (volinfo->type == GF_CLUSTER_TYPE_TIER) {
-                                if (volinfo->rebal.op != GD_OP_REMOVE_BRICK) {
-                                        glusterd_defrag_info_set (volinfo, dict,
-                                                  GF_DEFRAG_CMD_START_TIER,
-                                                  GF_DEFRAG_CMD_START,
-                                                  GD_OP_REBALANCE);
-                                }
-                                glusterd_restart_rebalance_for_volume (volinfo);
+                                svc = &(volinfo->tierd.svc);
+                                ret = svc->manager (svc, volinfo,
+                                                    PROC_START_NO_WAIT);
+                                if (ret)
+                                        goto out;
                         }
                         break;
                }
@@ -717,6 +772,10 @@ glusterd_pre_validate_aggr_rsp_dict (glusterd_op_t op,
                                 "response dictionaries.");
                         goto out;
                 }
+        case GD_OP_TIER_STATUS:
+        case GD_OP_DETACH_TIER_STATUS:
+        case GD_OP_TIER_START_STOP:
+        case GD_OP_REMOVE_TIER_BRICK:
                 break;
         case GD_OP_MAX_OPVERSION:
                 break;
@@ -1046,8 +1105,14 @@ glusterd_mgmt_v3_build_payload (dict_t **req, char **op_errstr, dict_t *dict,
                         dict_copy (dict, req_dict);
                 }
                         break;
+        case GD_OP_TIER_START_STOP:
+        case GD_OP_REMOVE_TIER_BRICK:
+        case GD_OP_DETACH_TIER_STATUS:
+        case GD_OP_TIER_STATUS:
+                        dict_copy (dict, req_dict);
+                        break;
         default:
-                break;
+                        break;
         }
 
         *req = req_dict;
@@ -1435,6 +1500,7 @@ glusterd_mgmt_v3_commit (glusterd_op_t op, dict_t *op_ctx, dict_t *req_dict,
         uuid_t               peer_uuid  = {0};
         xlator_t            *this       = NULL;
         glusterd_conf_t     *conf       = NULL;
+        int32_t              count      = 0;
 
         this = THIS;
         GF_ASSERT (this);
@@ -1488,6 +1554,7 @@ glusterd_mgmt_v3_commit (glusterd_op_t op, dict_t *op_ctx, dict_t *req_dict,
                 goto out;
         }
 
+
         dict_unref (rsp_dict);
         rsp_dict = NULL;
 
@@ -1504,8 +1571,25 @@ glusterd_mgmt_v3_commit (glusterd_op_t op, dict_t *op_ctx, dict_t *req_dict,
                 if (peerinfo->generation > txn_generation)
                         continue;
 
-                if (!peerinfo->connected)
+                if (!peerinfo->connected) {
+                        if (op == GD_OP_TIER_STATUS || op ==
+                                        GD_OP_DETACH_TIER_STATUS) {
+                                ret = dict_get_int32 (args.dict, "count",
+                                                      &count);
+                                if (ret)
+                                        gf_msg (this->name, GF_LOG_ERROR, 0,
+                                                GD_MSG_DICT_GET_FAILED,
+                                                "failed to get index");
+                                count++;
+                                ret = dict_set_int32 (args.dict, "count",
+                                                      count);
+                                if (ret)
+                                        gf_msg (this->name, GF_LOG_ERROR, 0,
+                                                GD_MSG_DICT_GET_FAILED,
+                                                "failed to set index");
+                        }
                         continue;
+                }
                 if (op != GD_OP_SYNC_VOLUME &&
                     peerinfo->state.state != GD_FRIEND_STATE_BEFRIENDED)
                         continue;
@@ -1538,6 +1622,7 @@ glusterd_mgmt_v3_commit (glusterd_op_t op, dict_t *op_ctx, dict_t *req_dict,
         gf_msg_debug (this->name, 0, "Sent commit req for %s to %d "
                 "peers. Returning %d", gd_op_list[op], peer_cnt, ret);
 out:
+        glusterd_op_modify_op_ctx (op, op_ctx);
         return ret;
 }
 
@@ -1684,7 +1769,12 @@ glusterd_mgmt_v3_post_validate (glusterd_op_t op, int32_t op_ret, dict_t *dict,
         }
 
         /* Copy the contents of dict like missed snaps info to req_dict */
-        dict_copy (dict, req_dict);
+        if (op != GD_OP_REMOVE_TIER_BRICK)
+                /* dict and req_dict has the same values during remove tier
+                 * brick (detach start) So this rewrite make the remove brick
+                 * id to become empty.
+                 * Avoiding to copy it retains the value. */
+                dict_copy (dict, req_dict);
 
         /* Post Validation on local node */
         ret = gd_mgmt_v3_post_validate_fn (op, op_ret, req_dict, op_errstr,