diff options
| author | Mohammed Rafi KC <rkavunga@redhat.com> | 2019-04-05 12:33:55 +0530 |
|---|---|---|
| committer | Atin Mukherjee <amukherj@redhat.com> | 2019-04-15 06:06:02 +0000 |
| commit | c27eee869f319fa2afbce31f1ab332d381015256 (patch) | |
| tree | 4d95e013e01bdfa57500e7c66ede776e7c06523a /xlators/mgmt/glusterd/src/glusterd-shd-svc.c | |
| parent | 8239efc76b56f1f4ce16bab263f7b355d8205820 (diff) | |
shd/mux: Fix coverity issues introduced by shd mux patch
CID 1400475: Null pointer dereferences (FORWARD_NULL)
CID 1400474: Null pointer dereferences (FORWARD_NULL)
CID 1400471: Code maintainability issues (UNUSED_VALUE)
CID 1400470: Null pointer dereferences (FORWARD_NULL)
CID 1400469: Memory - illegal accesses (USE_AFTER_FREE)
CID 1400467: Code maintainability issues (UNUSED_VALUE)
Change-Id: I0ca1c733be335c6e5844f44850f8066626ac40d4
updates: bz#789278
Signed-off-by: Mohammed Rafi KC <rkavunga@redhat.com>
Diffstat (limited to 'xlators/mgmt/glusterd/src/glusterd-shd-svc.c')
| -rw-r--r-- | xlators/mgmt/glusterd/src/glusterd-shd-svc.c | 6 |
1 files changed, 6 insertions, 0 deletions
diff --git a/xlators/mgmt/glusterd/src/glusterd-shd-svc.c b/xlators/mgmt/glusterd/src/glusterd-shd-svc.c index 47898434380..19eca9f2729 100644 --- a/xlators/mgmt/glusterd/src/glusterd-shd-svc.c +++ b/xlators/mgmt/glusterd/src/glusterd-shd-svc.c @@ -101,6 +101,8 @@ glusterd_shdsvc_init(void *data, glusterd_conn_t *mux_conn, svc->conn.rpc = rpc_clnt_ref(mux_svc->rpc); ret = snprintf(svc->conn.sockpath, sizeof(svc->conn.sockpath), "%s", mux_conn->sockpath); + if (ret < 0) + goto out; } else { ret = mkdir_p(logdir, 0755, _gf_true); if ((ret == -1) && (EEXIST != errno)) { @@ -673,6 +675,10 @@ glusterd_shdsvc_stop(glusterd_svc_t *svc, int sig) glusterd_volinfo_ref(volinfo); svc_proc->data = volinfo; ret = glusterd_svc_stop(svc, sig); + if (ret) { + glusterd_volinfo_unref(volinfo); + goto out; + } } if (!empty && pid != -1) { ret = glusterd_detach_svc(svc, volinfo, sig); |