summaryrefslogtreecommitdiffstats
path: root/xlators/mgmt/glusterd/src/glusterd-store.c
diff options
context:
space:
mode:
authorYaniv Kaul <ykaul@redhat.com>2018-07-16 11:25:41 +0300
committerAmar Tumballi <amarts@redhat.com>2018-07-17 05:41:46 +0000
commitc02a25515aba085c7dfa2033f830760e7458301d (patch)
tree1ea4c4510065b1c0b8081dcd6b00d63f84fb5152 /xlators/mgmt/glusterd/src/glusterd-store.c
parent42cf8a5f9218fd9e644d901dc53108daa183be5c (diff)
glusterd-store: fix coverity warning
The same variable 'len' was used both in the macros and the functions. (Introduced as part of commit 6dc5dfef819cad69d6d4b4c1c305efa74236ad84 ?) Change-Id: If434999d6470067f8a1e501c8e132561e8cd81ef updates: bz#1193929 Signed-off-by: Yaniv Kaul <ykaul@redhat.com>
Diffstat (limited to 'xlators/mgmt/glusterd/src/glusterd-store.c')
-rw-r--r--xlators/mgmt/glusterd/src/glusterd-store.c23
1 files changed, 8 insertions, 15 deletions
diff --git a/xlators/mgmt/glusterd/src/glusterd-store.c b/xlators/mgmt/glusterd/src/glusterd-store.c
index c42c5ea613e..47d74e8c284 100644
--- a/xlators/mgmt/glusterd/src/glusterd-store.c
+++ b/xlators/mgmt/glusterd/src/glusterd-store.c
@@ -1067,8 +1067,7 @@ out:
}
static void
-glusterd_store_voldirpath_set (glusterd_volinfo_t *volinfo, char *voldirpath,
- size_t len)
+glusterd_store_voldirpath_set (glusterd_volinfo_t *volinfo, char *voldirpath)
{
glusterd_conf_t *priv = NULL;
@@ -1080,8 +1079,7 @@ glusterd_store_voldirpath_set (glusterd_volinfo_t *volinfo, char *voldirpath,
}
static void
-glusterd_store_piddirpath_set (glusterd_volinfo_t *volinfo, char *piddirpath,
- size_t len)
+glusterd_store_piddirpath_set (glusterd_volinfo_t *volinfo, char *piddirpath)
{
glusterd_conf_t *priv = NULL;
@@ -1100,8 +1098,7 @@ glusterd_store_create_volume_dir (glusterd_volinfo_t *volinfo)
GF_ASSERT (volinfo);
- glusterd_store_voldirpath_set (volinfo, voldirpath,
- sizeof (voldirpath));
+ glusterd_store_voldirpath_set (volinfo, voldirpath);
ret = gf_store_mkdir (voldirpath);
gf_msg_debug (THIS->name, 0, "Returning with %d", ret);
@@ -1116,8 +1113,7 @@ glusterd_store_create_volume_run_dir (glusterd_volinfo_t *volinfo)
GF_ASSERT (volinfo);
- glusterd_store_piddirpath_set (volinfo, piddirpath,
- sizeof (piddirpath));
+ glusterd_store_piddirpath_set (volinfo, piddirpath);
ret = gf_store_mkdir (piddirpath);
@@ -1223,8 +1219,7 @@ glusterd_store_volfpath_set (glusterd_volinfo_t *volinfo, char *volfpath,
GF_ASSERT (volfpath);
GF_ASSERT (len <= PATH_MAX);
- glusterd_store_voldirpath_set (volinfo, voldirpath,
- sizeof (voldirpath));
+ glusterd_store_voldirpath_set (volinfo, voldirpath);
snprintf (volfpath, len, "%s/%s", voldirpath, GLUSTERD_VOLUME_INFO_FILE);
}
@@ -1237,8 +1232,7 @@ glusterd_store_node_state_path_set (glusterd_volinfo_t *volinfo,
GF_ASSERT (node_statepath);
GF_ASSERT (len <= PATH_MAX);
- glusterd_store_voldirpath_set (volinfo, voldirpath,
- sizeof (voldirpath));
+ glusterd_store_voldirpath_set (volinfo, voldirpath);
snprintf (node_statepath, len, "%s/%s", voldirpath,
GLUSTERD_NODE_STATE_FILE);
}
@@ -1252,8 +1246,7 @@ glusterd_store_quota_conf_path_set (glusterd_volinfo_t *volinfo,
GF_ASSERT (quota_conf_path);
GF_ASSERT (len <= PATH_MAX);
- glusterd_store_voldirpath_set (volinfo, voldirpath,
- sizeof (voldirpath));
+ glusterd_store_voldirpath_set (volinfo, voldirpath);
snprintf (quota_conf_path, len, "%s/%s", voldirpath,
GLUSTERD_VOLUME_QUOTA_CONFIG);
}
@@ -2400,7 +2393,7 @@ glusterd_store_retrieve_snapd (glusterd_volinfo_t *volinfo)
* tries to snapd related info from snapd.info file. But since there was
* no such file till now, the restore operation fails. Thus, to prevent
* it from happening check whether user serviceable snapshots features
- * is enabled before restoring snapd. If its disbaled, then simply
+ * is enabled before restoring snapd. If its disabled, then simply
* exit by returning success (without even checking for the snapd.info).
*/