diff options
author | Krishnan Parthasarathi <kp@gluster.com> | 2011-10-19 15:17:13 +0530 |
---|---|---|
committer | Vijay Bellur <vijay@gluster.com> | 2011-10-24 06:17:34 -0700 |
commit | ffb3e103e2ead4a1b207a57e75eee683e8de5ad9 (patch) | |
tree | 9879a291157491e506aee7b3bea92f6ffea571a9 /xlators/mgmt/glusterd/src/glusterd-utils.c | |
parent | 333bd9b59c4298a7cb7796f3bd4ee444376c68c6 (diff) |
glusterd: Fail volume 'modify' operations when rb is ongoing.
add-brick, stop-volume, remove-brick are the operations that are explicitly
'failed' when attempted while replace-brick is in progress.
Change-Id: Ia8034177e03a9ab10f9e8d5c8bc417427a1218e3
BUG: 3738
Reviewed-on: http://review.gluster.com/631
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Amar Tumballi <amar@gluster.com>
Reviewed-by: Vijay Bellur <vijay@gluster.com>
Diffstat (limited to 'xlators/mgmt/glusterd/src/glusterd-utils.c')
-rw-r--r-- | xlators/mgmt/glusterd/src/glusterd-utils.c | 39 |
1 files changed, 8 insertions, 31 deletions
diff --git a/xlators/mgmt/glusterd/src/glusterd-utils.c b/xlators/mgmt/glusterd/src/glusterd-utils.c index e2ab6d38bab..c7edefc03c8 100644 --- a/xlators/mgmt/glusterd/src/glusterd-utils.c +++ b/xlators/mgmt/glusterd/src/glusterd-utils.c @@ -2843,41 +2843,18 @@ glusterd_is_defrag_on (glusterd_volinfo_t *volinfo) return (volinfo->defrag != NULL); } -int -glusterd_is_replace_running (glusterd_volinfo_t *volinfo, glusterd_brickinfo_t *brickinfo) +gf_boolean_t +glusterd_is_rb_ongoing (glusterd_volinfo_t *volinfo) { - int ret = 0; - char *src_hostname = NULL; - char *brick_hostname = NULL; - - if (volinfo->src_brick) { - src_hostname = gf_strdup (volinfo->src_brick->hostname); - if (!src_hostname) { - ret = -1; - goto out; - } - } else { - gf_log ("glusterd", GF_LOG_DEBUG, - "replace brick is not running"); - goto out; - } + GF_ASSERT (volinfo); + gf_boolean_t ongoing = _gf_false; - brick_hostname = gf_strdup (brickinfo->hostname); - if (!brick_hostname) { - ret = -1; - goto out; - } - if (!glusterd_is_local_addr (src_hostname) && !glusterd_is_local_addr (brick_hostname)) { - if (glusterd_is_rb_started (volinfo) || glusterd_is_rb_paused (volinfo)) - ret = -1; + if (glusterd_is_rb_started (volinfo) + || glusterd_is_rb_paused (volinfo)) { + ongoing = _gf_true; } -out: - if (src_hostname) - GF_FREE (src_hostname); - if (brick_hostname) - GF_FREE (brick_hostname); - return ret; + return ongoing; } int |