diff options
author | Atin Mukherjee <amukherj@redhat.com> | 2015-07-03 11:34:20 +0530 |
---|---|---|
committer | Kaushal M <kaushal@redhat.com> | 2015-08-02 21:31:01 -0700 |
commit | aa80be0501a6893564b0dd40611cc91ad553ca6c (patch) | |
tree | 346b33b27c4d987109a071c9aba2f235c75cf544 /xlators/mgmt/glusterd/src/glusterd-utils.c | |
parent | 34517651a6c4507e389ffdb9ac83709bb3346a34 (diff) |
glusterd: Do not log failure if glusterd_get_txn_opinfo fails in gluster volume status
The first RPC call of gluster volume status fetches the list of the volume names
from GlusterD and during that time since no volume name is set in the dictionary
gluserd_get_txn_opinfo fails resulting into a failure log which is annoying to
the user considering this command is triggered frequently.
Fix is to have callers log it depending on the need
Change-Id: Ib60a56725208182175513c505c61bcb28148b2d0
BUG: 1238936
Signed-off-by: Atin Mukherjee <amukherj@redhat.com>
Reviewed-on: http://review.gluster.org/11520
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Tested-by: NetBSD Build System <jenkins@build.gluster.org>
Reviewed-by: Kaushal M <kaushal@redhat.com>
Diffstat (limited to 'xlators/mgmt/glusterd/src/glusterd-utils.c')
-rw-r--r-- | xlators/mgmt/glusterd/src/glusterd-utils.c | 7 |
1 files changed, 4 insertions, 3 deletions
diff --git a/xlators/mgmt/glusterd/src/glusterd-utils.c b/xlators/mgmt/glusterd/src/glusterd-utils.c index 9d525a66132..dc800a1a520 100644 --- a/xlators/mgmt/glusterd/src/glusterd-utils.c +++ b/xlators/mgmt/glusterd/src/glusterd-utils.c @@ -8276,10 +8276,11 @@ glusterd_volume_heal_use_rsp_dict (dict_t *aggr, dict_t *rsp_dict) ret = glusterd_get_txn_opinfo (txn_id, &txn_op_info); if (ret) { - gf_msg (THIS->name, GF_LOG_ERROR, 0, + gf_msg_callingfn (THIS->name, GF_LOG_ERROR, 0, GD_MSG_TRANS_OPINFO_GET_FAIL, - "Failed to get txn_op_info " - "for txn_id = %s", uuid_utoa (*txn_id)); + "Unable to get transaction opinfo " + "for transaction ID : %s", + uuid_utoa (*txn_id)); goto out; } |