summaryrefslogtreecommitdiffstats
path: root/xlators/mgmt/glusterd
diff options
context:
space:
mode:
authorPranith Kumar K <pranithk@gluster.com>2012-02-23 15:43:58 +0530
committerAnand Avati <avati@redhat.com>2012-03-17 23:31:38 -0700
commitca15758018b4da68da40c34f240de75b44cb49e9 (patch)
tree5bc73938a2d303940badfac5b918b6d177fcdfdc /xlators/mgmt/glusterd
parentcba2f84cd084fdf005977690dce3c54fa9f8b133 (diff)
cluster/afr: Enable eager-lock
Eager-lock is disabled by default. Use cluster.eager-lock on/off to change the config. write-behind on and eager-lock off is not supported configuration. In afr, when eager-lock is enabled the inode lock on fd is taken using the fd address as the lk-owner. So the lock is interchangableale between the inode-locks on the same fd. Change-Id: I7eef1ecd510f8028f5395dee882782da53c0de3f BUG: 802515 Signed-off-by: Pranith Kumar K <pranithk@gluster.com> Reviewed-on: http://review.gluster.com/2925 Tested-by: Gluster Build System <jenkins@build.gluster.com> Reviewed-by: Jeff Darcy <jdarcy@redhat.com> Reviewed-by: Anand Avati <avati@redhat.com>
Diffstat (limited to 'xlators/mgmt/glusterd')
-rw-r--r--xlators/mgmt/glusterd/src/glusterd-volgen.c89
1 files changed, 72 insertions, 17 deletions
diff --git a/xlators/mgmt/glusterd/src/glusterd-volgen.c b/xlators/mgmt/glusterd/src/glusterd-volgen.c
index 91696303a40..85691e6814b 100644
--- a/xlators/mgmt/glusterd/src/glusterd-volgen.c
+++ b/xlators/mgmt/glusterd/src/glusterd-volgen.c
@@ -109,22 +109,23 @@ struct volopt_map_entry {
static struct volopt_map_entry glusterd_volopt_map[] = {
- {"cluster.lookup-unhashed", "cluster/distribute", NULL, NULL, NO_DOC, 0},
- {"cluster.min-free-disk", "cluster/distribute", NULL, NULL, NO_DOC, 0},
- {"cluster.min-free-inodes", "cluster/distribute", NULL, NULL, NO_DOC, 0},
-
- {"cluster.entry-change-log", "cluster/replicate", NULL, NULL, NO_DOC, 0},
- {"cluster.read-subvolume", "cluster/replicate", NULL, NULL, NO_DOC, 0},
- {"cluster.background-self-heal-count", "cluster/replicate", NULL, NULL, NO_DOC, 0},
- {"cluster.metadata-self-heal", "cluster/replicate", NULL, NULL, NO_DOC, 0},
- {"cluster.data-self-heal", "cluster/replicate", NULL, NULL, NO_DOC, 0},
- {"cluster.entry-self-heal", "cluster/replicate", NULL, NULL, NO_DOC, 0},
- {"cluster.self-heal-daemon", "cluster/replicate", "!self-heal-daemon", NULL, NO_DOC, 0},
- {"cluster.strict-readdir", "cluster/replicate", NULL, NULL, NO_DOC, 0},
- {"cluster.self-heal-window-size", "cluster/replicate", "data-self-heal-window-size", NULL, DOC, 0},
- {"cluster.data-change-log", "cluster/replicate", NULL, NULL, NO_DOC, 0},
- {"cluster.metadata-change-log", "cluster/replicate", NULL, NULL, NO_DOC, 0},
- {"cluster.data-self-heal-algorithm", "cluster/replicate", "data-self-heal-algorithm", NULL,DOC, 0},
+ {"cluster.lookup-unhashed", "cluster/distribute", NULL, NULL, NO_DOC, 0 },
+ {"cluster.min-free-disk", "cluster/distribute", NULL, NULL, NO_DOC, 0 },
+ {"cluster.min-free-inodes", "cluster/distribute", NULL, NULL, NO_DOC, 0 },
+
+ {"cluster.entry-change-log", "cluster/replicate", NULL, NULL, NO_DOC, 0 },
+ {"cluster.read-subvolume", "cluster/replicate", NULL, NULL, NO_DOC, 0 },
+ {"cluster.background-self-heal-count", "cluster/replicate", NULL, NULL, NO_DOC, 0 },
+ {"cluster.metadata-self-heal", "cluster/replicate", NULL, NULL, NO_DOC, 0 },
+ {"cluster.data-self-heal", "cluster/replicate", NULL, NULL, NO_DOC, 0 },
+ {"cluster.entry-self-heal", "cluster/replicate", NULL, NULL, NO_DOC, 0 },
+ {"cluster.self-heal-daemon", "cluster/replicate", "!self-heal-daemon" , NULL, NO_DOC, 0 },
+ {"cluster.strict-readdir", "cluster/replicate", NULL, NULL, NO_DOC, 0 },
+ {"cluster.self-heal-window-size", "cluster/replicate", "data-self-heal-window-size", NULL, DOC, 0},
+ {"cluster.data-change-log", "cluster/replicate", NULL, NULL, NO_DOC, 0 },
+ {"cluster.metadata-change-log", "cluster/replicate", NULL, NULL, NO_DOC, 0 },
+ {"cluster.data-self-heal-algorithm", "cluster/replicate", "data-self-heal-algorithm", NULL,DOC, 0},
+ {"cluster.eager-lock", "cluster/replicate", NULL, NULL, NO_DOC, 0 },
{"cluster.quorum-type", "cluster/replicate", "quorum-type", NULL, NO_DOC, 0},
{"cluster.quorum-count", "cluster/replicate", "quorum-count", NULL, NO_DOC, 0},
@@ -1962,7 +1963,6 @@ get_key_from_volopt ( struct volopt_map_entry *vme, char **key)
return ret;
}
-
int
glusterd_get_volopt_content (gf_boolean_t xml_out)
{
@@ -3322,6 +3322,57 @@ out:
}
int
+validate_wb_eagerlock (glusterd_volinfo_t *volinfo, dict_t *val_dict,
+ char **op_errstr)
+{
+ int ret = -1;
+ gf_boolean_t wb_val = _gf_false;
+ gf_boolean_t el_val = _gf_false;
+ char msg[2048] = {0};
+ char *wb_key = NULL;
+ char *el_key = NULL;
+
+ wb_key = "performance.write-behind";
+ el_key = "cluster.eager-lock";
+ ret = dict_get_str_boolean (val_dict, wb_key, -1);
+ if (ret < 0)
+ goto check_eager_lock;
+ wb_val = ret;
+ ret = glusterd_volinfo_get_boolean (volinfo, el_key);
+ if (ret < 0)
+ goto out;
+ el_val = ret;
+ goto done;
+
+check_eager_lock:
+ ret = dict_get_str_boolean (val_dict, el_key, -1);
+ if (ret < 0) {
+ ret = 0; //Keys of intereset to this fn are not present.
+ goto out;
+ }
+ el_val = ret;
+ ret = glusterd_volinfo_get_boolean (volinfo, wb_key);
+ if (ret < 0)
+ goto out;
+ wb_val = ret;
+ goto done;
+
+done:
+ ret = 0;
+ if (!wb_val && el_val) {
+ ret = -1;
+ snprintf (msg, sizeof (msg), "%s off and %s on is not "
+ "valid configuration", wb_key, el_key);
+ gf_log ("glusterd", GF_LOG_ERROR, msg);
+ if (op_errstr)
+ *op_errstr = gf_strdup (msg);
+ goto out;
+ }
+out:
+ return ret;
+}
+
+int
validate_clientopts (glusterd_volinfo_t *volinfo,
dict_t *val_dict,
char **op_errstr)
@@ -3466,6 +3517,10 @@ glusterd_validate_reconfopts (glusterd_volinfo_t *volinfo, dict_t *val_dict,
goto out;
}
+ ret = validate_wb_eagerlock (volinfo, val_dict, op_errstr);
+ if (ret)
+ goto out;
+
ret = validate_clientopts (volinfo, val_dict, op_errstr);
if (ret) {
gf_log ("", GF_LOG_DEBUG,