diff options
| author | Niels de Vos <ndevos@redhat.com> | 2015-02-27 15:30:04 +0100 |
|---|---|---|
| committer | Niels de Vos <ndevos@redhat.com> | 2015-02-28 09:30:03 -0800 |
| commit | 32dd227726ce60b2e60b8df61ca174d96a1b8b34 (patch) | |
| tree | bd50617f0a1a689ab01dffeec613701c58e7fe28 /xlators/nfs/server/src/acl3.c | |
| parent | 5b4755e9494b80f7b57c1515773991c962af0a2a (diff) | |
nfs: nfs3_stat_to_fattr3() improvement
During a review of backorti http://review.gluster.org/9170, Kaleb points
out:
ick, return-by-value. About 50% slower than passing a pointer to the
target struct.
Change-Id: I4464e6a4e50d82d446a834892d0308332b7c32d0
BUG: 1197142
Reported-by: Kaleb KEITHLEY <kkeithle@redhat.com>
Signed-off-by: Niels de Vos <ndevos@redhat.com>
Reviewed-on: http://review.gluster.org/9772
Reviewed-by: Kaleb KEITHLEY <kkeithle@redhat.com>
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Diffstat (limited to 'xlators/nfs/server/src/acl3.c')
| -rw-r--r-- | xlators/nfs/server/src/acl3.c | 6 |
1 files changed, 3 insertions, 3 deletions
diff --git a/xlators/nfs/server/src/acl3.c b/xlators/nfs/server/src/acl3.c index b00e8170ebd..b1e5d95d087 100644 --- a/xlators/nfs/server/src/acl3.c +++ b/xlators/nfs/server/src/acl3.c @@ -49,8 +49,8 @@ nfs3_call_state_init (struct nfs3_state *s, rpcsvc_request_t *req, xlator_t *v); extern int nfs3_fh_validate (struct nfs3_fh *fh); -extern fattr3 -nfs3_stat_to_fattr3 (struct iatt *buf); +extern void +nfs3_stat_to_fattr3 (struct iatt *buf, fattr3 *fa); #define acl3_validate_nfs3_state(request, state, status, label, retval) \ do { \ @@ -409,7 +409,7 @@ acl3_stat_cbk (call_frame_t *frame, void *cookie, xlator_t *this, getaclreply->attr_follows = TRUE; deviceid = nfs3_request_xlator_deviceid (cs->req); nfs3_map_deviceid_to_statdev (buf, deviceid); - getaclreply->attr = nfs3_stat_to_fattr3 (buf); + nfs3_stat_to_fattr3 (buf, &(getaclreply->attr)); nfs_request_user_init (&nfu, cs->req); if (buf->ia_type == IA_IFDIR) { |