diff options
| author | Yaniv Kaul <ykaul@redhat.com> | 2018-10-13 00:56:42 +0300 |
|---|---|---|
| committer | Amar Tumballi <amarts@redhat.com> | 2018-10-16 06:33:29 +0000 |
| commit | 98f68cf115a30a101d3be2252ecbe1391720ed88 (patch) | |
| tree | 4a9da66f8833a936eba95fc078a4605acd632f4f /xlators/performance/io-cache/src/page.c | |
| parent | fd70a7d790710da01a8ddd56785a28ab54e07550 (diff) | |
Multiple xlators: perform gettimeofday() not under lock
While it may slightly reduce accuracy, I think it's better to
acquire the time outside a lock and then memcpy the value while
under lock.
Compile-tested only!
updates: bz#1193929
Signed-off-by: Yaniv Kaul <ykaul@redhat.com>
Change-Id: Ic8fb94a56c4fa2d3b13e59767e13646fb39342ba
Diffstat (limited to 'xlators/performance/io-cache/src/page.c')
| -rw-r--r-- | xlators/performance/io-cache/src/page.c | 6 |
1 files changed, 5 insertions, 1 deletions
diff --git a/xlators/performance/io-cache/src/page.c b/xlators/performance/io-cache/src/page.c index dada4ebc55b..c376ade0fba 100644 --- a/xlators/performance/io-cache/src/page.c +++ b/xlators/performance/io-cache/src/page.c @@ -413,6 +413,9 @@ ioc_fault_cbk(call_frame_t *frame, void *cookie, xlator_t *this, int32_t op_ret, ioc_waitq_t *waitq = NULL; size_t iobref_page_size = 0; char zero_filled = 0; + struct timeval tv = { + 0, + }; GF_ASSERT(frame); @@ -428,6 +431,7 @@ ioc_fault_cbk(call_frame_t *frame, void *cookie, xlator_t *this, int32_t op_ret, zero_filled = ((op_ret >= 0) && (stbuf->ia_mtime == 0)); + gettimeofday(&tv, NULL); ioc_inode_lock(ioc_inode); { if (op_ret == -1 || @@ -444,7 +448,7 @@ ioc_fault_cbk(call_frame_t *frame, void *cookie, xlator_t *this, int32_t op_ret, ioc_inode->cache.mtime_nsec = stbuf->ia_mtime_nsec; } - gettimeofday(&ioc_inode->cache.tv, NULL); + memcpy(&ioc_inode->cache.tv, &tv, sizeof(struct timeval)); if (op_ret < 0) { /* error, readv returned -1 */ |