summaryrefslogtreecommitdiffstats
path: root/xlators/performance/io-cache
diff options
context:
space:
mode:
authorHari Gowtham <hgowtham@redhat.com>2015-08-13 12:53:33 +0530
committerRaghavendra G <rgowdapp@redhat.com>2015-08-31 20:28:53 -0700
commit0baf199b065ee3adcbf36a503ac91737ab39f7e1 (patch)
tree98211fe02551346765b2e7b95a2b7438198f2669 /xlators/performance/io-cache
parent9f52d22690b3b0aac0a736eb15fe649fde6286b5 (diff)
performance translators : porting the missing gf_log to gf_msg
Change-Id: I5cc2b4669b164fe09637c86da05d2d94589dd7e4 BUG: 1253149 Signed-off-by: Hari Gowtham <hgowtham@redhat.com> Reviewed-on: http://review.gluster.org/11906 Tested-by: NetBSD Build System <jenkins@build.gluster.org> Reviewed-by: Raghavendra G <rgowdapp@redhat.com>
Diffstat (limited to 'xlators/performance/io-cache')
-rw-r--r--xlators/performance/io-cache/src/io-cache-messages.h28
-rw-r--r--xlators/performance/io-cache/src/ioc-inode.c6
-rw-r--r--xlators/performance/io-cache/src/page.c3
3 files changed, 33 insertions, 4 deletions
diff --git a/xlators/performance/io-cache/src/io-cache-messages.h b/xlators/performance/io-cache/src/io-cache-messages.h
index 5c4fbea46fc..ba6b55d1299 100644
--- a/xlators/performance/io-cache/src/io-cache-messages.h
+++ b/xlators/performance/io-cache/src/io-cache-messages.h
@@ -40,7 +40,7 @@
*/
#define GLFS_IO_CACHE_BASE GLFS_MSGID_COMP_IO_CACHE
-#define GLFS_IO_CACHE_NUM_MESSAGES 6
+#define GLFS_IO_CACHE_NUM_MESSAGES 9
#define GLFS_MSGID_END (GLFS_IO_CACHE_BASE + GLFS_IO_CACHE_NUM_MESSAGES + 1)
/* Messages with message IDs */
@@ -103,6 +103,32 @@
#define IO_CACHE_MSG_INODE_NULL (GLFS_IO_CACHE_BASE + 6)
+/*!
+ * @messageid
+ * @diagnosis
+ * @recommendedaction None
+ *
+ */
+
+#define IO_CACHE_MSG_PAGE_WAIT_VALIDATE (GLFS_IO_CACHE_BASE + 7)
+
+/*!
+ * @messageid
+ * @diagnosis
+ * @recommendedaction None
+ *
+ */
+
+#define IO_CACHE_MSG_STR_COVERSION_FAILED (GLFS_IO_CACHE_BASE + 8)
+
+/*!
+ * @messageid
+ * @diagnosis
+ * @recommendedaction None
+ *
+ */
+
+#define IO_CACHE_MSG_WASTED_COPY (GLFS_IO_CACHE_BASE + 9)
/*------------*/
#define glfs_msg_end_x GLFS_MSGID_END, "Invalid: End of messages"
diff --git a/xlators/performance/io-cache/src/ioc-inode.c b/xlators/performance/io-cache/src/ioc-inode.c
index 53bbd0448f2..cee3bad8c22 100644
--- a/xlators/performance/io-cache/src/ioc-inode.c
+++ b/xlators/performance/io-cache/src/ioc-inode.c
@@ -47,7 +47,8 @@ ptr_to_str (void *ptr)
ret = gf_asprintf (&str, "%p", ptr);
if (-1 == ret) {
- gf_log ("io-cache", GF_LOG_WARNING,
+ gf_msg ("io-cache", GF_LOG_WARNING, 0,
+ IO_CACHE_MSG_STR_COVERSION_FAILED,
"asprintf failed while converting ptr to str");
str = NULL;
goto out;
@@ -95,7 +96,8 @@ ioc_inode_wakeup (call_frame_t *frame, ioc_inode_t *ioc_inode,
cache_still_valid = 0;
if (!waiter) {
- gf_log (frame->this->name, GF_LOG_WARNING,
+ gf_msg (frame->this->name, GF_LOG_WARNING, 0,
+ IO_CACHE_MSG_PAGE_WAIT_VALIDATE,
"cache validate called without any "
"page waiting to be validated");
}
diff --git a/xlators/performance/io-cache/src/page.c b/xlators/performance/io-cache/src/page.c
index a0f01da6d2e..50f5e190e21 100644
--- a/xlators/performance/io-cache/src/page.c
+++ b/xlators/performance/io-cache/src/page.c
@@ -467,7 +467,8 @@ ioc_fault_cbk (call_frame_t *frame, void *cookie, xlator_t *this,
if (!page) {
/* page was flushed */
/* some serious bug ? */
- gf_log (frame->this->name, GF_LOG_WARNING,
+ gf_msg (frame->this->name, GF_LOG_WARNING, 0,
+ IO_CACHE_MSG_WASTED_COPY,
"wasted copy: %"PRId64"[+%"PRId64"] "
"ioc_inode=%p", offset,
table->page_size, ioc_inode);