diff options
| author | Raghavendra G <raghavendra@gluster.com> | 2012-03-27 08:47:35 +0530 |
|---|---|---|
| committer | Vijay Bellur <vijay@gluster.com> | 2012-03-27 11:29:05 -0700 |
| commit | af0eb165f624c6a76e84e5a0c78881715ceae7c3 (patch) | |
| tree | 41ab9d82ae0b2564143337a17526a183b6f6baad /xlators/performance | |
| parent | c3c4ee24a64a2447f77788cb84559f1e07a21e04 (diff) | |
performance/write-behind: queue setattr fop with writes always.v3.3.0qa32
stat returned in setattr_cbk can be cached by the kernel. Hence it is
always necessary that we return correct stat, which implies that setattr
should not be out of order with respect to write fops.
Change-Id: I305feeb4802f8a41ffaf032100832cbd65dfc5c1
BUG: 765443
Signed-off-by: Raghavendra G <raghavendra@gluster.com>
Reviewed-on: http://review.gluster.com/3011
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Amar Tumballi <amarts@redhat.com>
Reviewed-by: Vijay Bellur <vijay@gluster.com>
Diffstat (limited to 'xlators/performance')
| -rw-r--r-- | xlators/performance/write-behind/src/write-behind.c | 9 |
1 files changed, 1 insertions, 8 deletions
diff --git a/xlators/performance/write-behind/src/write-behind.c b/xlators/performance/write-behind/src/write-behind.c index d1b9f6feb37..9bb3673fcd7 100644 --- a/xlators/performance/write-behind/src/write-behind.c +++ b/xlators/performance/write-behind/src/write-behind.c @@ -1283,13 +1283,6 @@ wb_setattr (call_frame_t *frame, xlator_t *this, loc_t *loc, frame->local = local; - if (!(valid & (GF_SET_ATTR_ATIME | GF_SET_ATTR_MTIME))) { - STACK_WIND (frame, wb_setattr_cbk, FIRST_CHILD (this), - FIRST_CHILD (this)->fops->setattr, loc, stbuf, - valid, xdata); - goto out; - } - if (loc->inode) { /* FIXME: fd_lookup extends life of fd till the execution @@ -1340,7 +1333,7 @@ unwind: if (stub) { call_stub_destroy (stub); } -out: + return 0; } |