protocol/client: sequence CHILD_UP, CHILD_DOWN etc notifications

... from all bricks in the volume

This patch is important in the context of MT epoll. With MT epoll,
notification events from client xlators could reach cluster xlators like
afr, dht, ec, stripe etc. in different orders.

For e.g, In a distributed replicate volume of 2 bricks, namely Brick1
and Brick2, the following network events are observed by a mount
process.

- connection to Brick1 is broken.
- connection to Brick1 has been restored.

- connection to Brick2 is broken.
- connection to Brick2 has been restored.

Without establishing a total ordering of events, we can't guarantee that
cluster xlators like afr, dht perceive them in the same order.  While we
would expect afr (say) to perceive it as only one of Brick1 and Brick2
going down at any given time, it is possible for the notification of
Brick2 going offline to race with the notification of Brick1 coming back
online.

Change-Id: I78f5a52bfb05593335d0e9ad53ebfff98995593d
BUG: 1104462
Signed-off-by: Krishnan Parthasarathi <kparthas@redhat.com>
Reviewed-on: http://review.gluster.org/9591
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Vijay Bellur <vbellur@redhat.com>

1 files changed, 7 insertions, 8 deletions

diff --git a/xlators/protocol/client/src/client-handshake.c b/xlators/protocol/client/src/client-handshake.c
index 42b7ac0745e..531b38eaf83 100644
--- a/xlators/protocol/client/src/client-handshake.c
+++ b/xlators/protocol/client/src/client-handshake.c
@@ -131,12 +131,11 @@ client_notify_parents_child_up (xlator_t *this)
         int          ret  = 0;
 
         conf = this->private;
-        ret = default_notify (this, GF_EVENT_CHILD_UP, NULL);
+        ret = client_notify_dispatch (this, GF_EVENT_CHILD_UP, NULL);
         if (ret)
                 gf_log (this->name, GF_LOG_INFO,
                         "notify of CHILD_UP failed");
 
-        conf->last_sent_event = GF_EVENT_CHILD_UP;
         return 0;
 }
 
@@ -1146,11 +1145,12 @@ client_setvolume_cbk (struct rpc_req *req, struct iovec *iov, int count, void *m
                         op_ret = 0;
                 }
                 if (op_errno == ESTALE) {
-                        ret = default_notify (this, GF_EVENT_VOLFILE_MODIFIED, NULL);
+                        ret = client_notify_dispatch (this,
+                                                      GF_EVENT_VOLFILE_MODIFIED,
+                                                      NULL);
                         if (ret)
                                 gf_log (this->name, GF_LOG_INFO,
                                         "notify of VOLFILE_MODIFIED failed");
-                        conf->last_sent_event = GF_EVENT_VOLFILE_MODIFIED;
                 }
                 goto out;
         }
@@ -1223,13 +1223,12 @@ client_setvolume_cbk (struct rpc_req *req, struct iovec *iov, int count, void *m
 out:
         if (auth_fail) {
                 gf_log (this->name, GF_LOG_INFO, "sending AUTH_FAILED event");
-                ret = default_notify (this, GF_EVENT_AUTH_FAILED, NULL);
+                ret = client_notify_dispatch (this, GF_EVENT_AUTH_FAILED, NULL);
                 if (ret)
                         gf_log (this->name, GF_LOG_INFO,
                                 "notify of AUTH_FAILED failed");
                 conf->connecting = 0;
                 conf->connected = 0;
-                conf->last_sent_event = GF_EVENT_AUTH_FAILED;
                 ret = -1;
         }
         if (-1 == op_ret) {
@@ -1238,11 +1237,11 @@ out:
                  * tell the parents that i am all ok..
                  */
                 gf_log (this->name, GF_LOG_INFO, "sending CHILD_CONNECTING event");
-                ret = default_notify (this, GF_EVENT_CHILD_CONNECTING, NULL);
+                ret = client_notify_dispatch (this, GF_EVENT_CHILD_CONNECTING,
+                                              NULL);
                 if (ret)
                         gf_log (this->name, GF_LOG_INFO,
                                 "notify of CHILD_CONNECTING failed");
-                conf->last_sent_event = GF_EVENT_CHILD_CONNECTING;
                 conf->connecting= 1;
                 ret = 0;
         }