diff options
| author | Amar Tumballi <amar@gluster.com> | 2012-02-14 15:05:19 +0530 |
|---|---|---|
| committer | Vijay Bellur <vijay@gluster.com> | 2012-02-20 00:46:27 -0800 |
| commit | c0b8e886cac4ef0f16d5f93adab02229bb1414cd (patch) | |
| tree | 03f5bc6550d5f2501d5b968776f4bb0ee8025310 /xlators/protocol/client/src | |
| parent | 975933a25d14cbac861e809b40c6edd01acaa28d (diff) | |
iobuf: use 'iobuf_get2()' to get variable sized buffers
added 'TODO' in places where it is missing.
Change-Id: Ia802c94e3bb76930f7c88c990f078525be5459f5
Signed-off-by: Amar Tumballi <amar@gluster.com>
BUG: 765264
Reviewed-on: http://review.gluster.com/388
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Vijay Bellur <vijay@gluster.com>
Diffstat (limited to 'xlators/protocol/client/src')
| -rw-r--r-- | xlators/protocol/client/src/client3_1-fops.c | 30 |
1 files changed, 17 insertions, 13 deletions
diff --git a/xlators/protocol/client/src/client3_1-fops.c b/xlators/protocol/client/src/client3_1-fops.c index 234b0dd6e03..e3d6d36dba6 100644 --- a/xlators/protocol/client/src/client3_1-fops.c +++ b/xlators/protocol/client/src/client3_1-fops.c @@ -2493,6 +2493,8 @@ client3_1_lookup (call_frame_t *frame, xlator_t *this, } /* TODO: what is the size we should send ? */ + /* This change very much depends on quick-read + changes */ rsp_iobuf = iobuf_get (this->ctx->iobuf_pool); if (rsp_iobuf == NULL) { goto unwind; @@ -3409,8 +3411,7 @@ client3_1_readv (call_frame_t *frame, xlator_t *this, memcpy (req.gfid, args->fd->inode->gfid, 16); - /* TODO: what is the size we should send ? */ - rsp_iobuf = iobuf_get (this->ctx->iobuf_pool); + rsp_iobuf = iobuf_get2 (this->ctx->iobuf_pool, args->size); if (rsp_iobuf == NULL) { op_errno = ENOMEM; goto unwind; @@ -3959,8 +3960,8 @@ client3_1_fgetxattr (call_frame_t *frame, xlator_t *this, goto unwind; } - /* TODO: what is the size we should send ? */ - rsp_iobuf = iobuf_get (this->ctx->iobuf_pool); + /* TODO: what is the size we should send ? */ + rsp_iobuf = iobuf_get2 (this->ctx->iobuf_pool, 8 * GF_UNIT_KB); if (rsp_iobuf == NULL) { op_errno = ENOMEM; goto unwind; @@ -4062,8 +4063,8 @@ client3_1_getxattr (call_frame_t *frame, xlator_t *this, goto unwind; } - /* TODO: what is the size we should send ? */ - rsp_iobuf = iobuf_get (this->ctx->iobuf_pool); + /* TODO: what is the size we should send ? */ + rsp_iobuf = iobuf_get2 (this->ctx->iobuf_pool, 8 * GF_UNIT_KB); if (rsp_iobuf == NULL) { op_errno = ENOMEM; goto unwind; @@ -4188,8 +4189,8 @@ client3_1_xattrop (call_frame_t *frame, xlator_t *this, goto unwind; } - /* TODO: what is the size we should send ? */ - rsp_iobuf = iobuf_get (this->ctx->iobuf_pool); + /* TODO: what is the size we should send ? */ + rsp_iobuf = iobuf_get2 (this->ctx->iobuf_pool, 8 * GF_UNIT_KB); if (rsp_iobuf == NULL) { op_errno = ENOMEM; goto unwind; @@ -4308,8 +4309,8 @@ client3_1_fxattrop (call_frame_t *frame, xlator_t *this, goto unwind; } - /* TODO: what is the size we should send ? */ - rsp_iobuf = iobuf_get (this->ctx->iobuf_pool); + /* TODO: what is the size we should send ? */ + rsp_iobuf = iobuf_get2 (this->ctx->iobuf_pool, 8 * GF_UNIT_KB); if (rsp_iobuf == NULL) { op_errno = ENOMEM; goto unwind; @@ -4880,7 +4881,9 @@ client3_1_readdir (call_frame_t *frame, xlator_t *this, goto unwind; } - /* TODO: what is the size we should send ? */ + /* TODO: what is the size we should send ? */ + /* This iobuf will live for only receiving the response, + so not harmful */ rsp_iobuf = iobuf_get (this->ctx->iobuf_pool); if (rsp_iobuf == NULL) { goto unwind; @@ -4890,8 +4893,7 @@ client3_1_readdir (call_frame_t *frame, xlator_t *this, iobuf_unref (rsp_iobuf); rsphdr = &vector[0]; rsphdr->iov_base = iobuf_ptr (rsp_iobuf); - rsphdr->iov_len - = iobuf_pagesize (rsp_iobuf); + rsphdr->iov_len = iobuf_pagesize (rsp_iobuf); count = 1; rsp_iobuf = NULL; local->iobref = rsp_iobref; @@ -4983,6 +4985,8 @@ client3_1_readdirp (call_frame_t *frame, xlator_t *this, } /* TODO: what is the size we should send ? */ + /* This iobuf will live for only receiving the response, + so not harmful */ rsp_iobuf = iobuf_get (this->ctx->iobuf_pool); if (rsp_iobuf == NULL) { goto unwind; |