diff options
| author | Amar Tumballi <amar@gluster.com> | 2010-07-02 04:55:28 +0000 |
|---|---|---|
| committer | Anand V. Avati <avati@dev.gluster.com> | 2010-07-02 05:17:03 -0700 |
| commit | 2f15ffd6b5beef9abd501c594bc3cb38c2683f77 (patch) | |
| tree | 107176560e1a97c42f3535380ef49d4dee3b0cd6 /xlators/protocol/server/src/server3_1-fops.c | |
| parent | 3dc79ca8e6119f5ff61058cc87f9a4fc251017ef (diff) | |
NULL dereference fixes in code base after running with 'clang'
* 212 logical (NULL deref/divide by zero) errors reduced to 28
(27 of them in contrib/ and lex part of codebase, 1 is invalid)
* 11 API errors reduced to 0
Signed-off-by: Amar Tumballi <amar@gluster.com>
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>
BUG: 966 (NULL check for avoiding NULL dereferencing of pointers..)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=966
Diffstat (limited to 'xlators/protocol/server/src/server3_1-fops.c')
| -rw-r--r-- | xlators/protocol/server/src/server3_1-fops.c | 8 |
1 files changed, 4 insertions, 4 deletions
diff --git a/xlators/protocol/server/src/server3_1-fops.c b/xlators/protocol/server/src/server3_1-fops.c index 686c0350d0b..c04861ddf10 100644 --- a/xlators/protocol/server/src/server3_1-fops.c +++ b/xlators/protocol/server/src/server3_1-fops.c @@ -4737,7 +4737,7 @@ server_lookup (rpcsvc_request_t *req) if (buf == NULL) { gf_log (conn->bound_xl->name, GF_LOG_ERROR, "out of memory"); - goto err; + goto out; } ret = dict_unserialize (buf, args.dict.dict_len, @@ -4748,7 +4748,7 @@ server_lookup (rpcsvc_request_t *req) "unserialize req-buffer to dictionary", frame->root->unique, state->resolve.path, state->resolve.ino); - goto err; + goto out; } state->dict = xattr_req; @@ -4761,7 +4761,7 @@ server_lookup (rpcsvc_request_t *req) resolve_and_resume (frame, server_lookup_resume); return 0; -err: +out: if (xattr_req) dict_unref (xattr_req); @@ -4771,7 +4771,7 @@ err: server_lookup_cbk (frame, NULL, frame->this, -1, EINVAL, NULL, NULL, NULL, NULL); - +err: return 0; } |