diff options
| author | Jeff Darcy <jdarcy@redhat.com> | 2015-01-06 10:03:49 -0500 |
|---|---|---|
| committer | Vijay Bellur <vbellur@redhat.com> | 2015-01-09 10:04:11 -0800 |
| commit | 548547b2e41c8e2cf79b929405cf18aecbdedebc (patch) | |
| tree | 8dba5d41c08edf366244e6679157419c999b1762 /xlators/protocol/server | |
| parent | 9408dc7b416ca80b3b8d8ecae2ef75c7e9cd21cd (diff) | |
transport: fix default behavior for SSL authorization
Previously, enabling SSL authentication/encryption but not authorization
required explicitly setting ssl-allow=*. Now that same behavior is the
default (i.e. when ssl-allow is not set).
Also, there's no reason that a name used for *login* auth (typically a
UUID for internal purposes or a human name when using SSL) should
validate as an RFC-compliant host name or IP address. Therefore the
validation only occurs when the auth type is "addr" (not "login" or
anything else).
Change-Id: I01485ff4f0ab37de4b182858235a5fb0cf4c3c7d
BUG: 1179208
Signed-off-by: Jeff Darcy <jdarcy@redhat.com>
Reviewed-on: http://review.gluster.org/9397
Reviewed-by: Krishnan Parthasarathi <kparthas@redhat.com>
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Vijay Bellur <vbellur@redhat.com>
Diffstat (limited to 'xlators/protocol/server')
| -rw-r--r-- | xlators/protocol/server/src/server.c | 6 |
1 files changed, 6 insertions, 0 deletions
diff --git a/xlators/protocol/server/src/server.c b/xlators/protocol/server/src/server.c index 6f6be52ab15..0dfe19a16b4 100644 --- a/xlators/protocol/server/src/server.c +++ b/xlators/protocol/server/src/server.c @@ -380,6 +380,12 @@ _check_for_auth_option (dict_t *d, char *k, data_t *v, if (!tail) goto out; + if (strncmp(tail, "addr.", 5) != 0) { + gf_log (xl->name, GF_LOG_INFO, + "skip format check for non-addr auth option %s", k); + goto out; + } + /* fast fwd thru module type */ tail = strchr (tail, '.'); if (!tail) |