diff options
author | Pranith Kumar K <pranithk@gluster.com> | 2012-07-25 20:46:53 +0530 |
---|---|---|
committer | Anand Avati <avati@redhat.com> | 2012-07-31 23:47:23 -0700 |
commit | 9fcc3f4dede2829d457b6e1c76f53c25ba790988 (patch) | |
tree | 7bbc0175b0fe44eedad871d2e39fd7843cfd3db2 /xlators/protocol | |
parent | b18c913f58aadcadb830b59d8ed8979d18c0e0d0 (diff) |
cluster/afr: Handle failures in fop_cbk gracefully
RCA:
Afr crashes when a last fop response fails and
'fop output' arguments are NULL. Afr does not handle
these gracefully.
Fix:
Changed the fops to not access the 'fop output' arguments
in case of failures.
Tests:
Changed afr wind_cbk code to fail the last response by setting
op_ret as -1 and op_errno as ENOMEM and setting all other output
variables as NULL to test the change. Removed the code to verify
success cases. No crashes or errors seen.
Change-Id: Iad9bc54db093a162f85bfb8dbeeda5b95acd21d8
BUG: 844689
Signed-off-by: Pranith Kumar K <pranithk@gluster.com>
Reviewed-on: http://review.gluster.com/3760
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Amar Tumballi <amarts@redhat.com>
Reviewed-by: Anand Avati <avati@redhat.com>
Diffstat (limited to 'xlators/protocol')
0 files changed, 0 insertions, 0 deletions