diff options
| author | Atin Mukherjee <amukherj@redhat.com> | 2014-09-04 21:47:50 +0530 |
|---|---|---|
| committer | Kaushal M <kaushal@redhat.com> | 2014-10-15 03:02:40 -0700 |
| commit | 6c13daed1d601df76cfd1973d3ce800afa877fd2 (patch) | |
| tree | dd739590b1b07d49c04f1da658b779b2f3e81922 /xlators/protocol | |
| parent | 7e8eefca2caaaa61e1b31b747384f660c595d9c9 (diff) | |
glusterd: statedump support
Although glusterd currently has statedump support but it doesn't dump its
context information. Implementing glusterd_dump_priv function to export per-node
glusterd information would be useful for debugging bugs. Once implemented, we
could enhance sos-report to fetch this information. This would potentially
reduce our time to root cause and data needed for debugability can be dumped
gradually.
Following is the main items of the dump list targeted in this patch :
* Supported max/min op-version and current op-version
* Information about peer list
* Information about peer list involved while a transaction is going on
(xaction_peers)
* option dictionary in glusterd_conf_t
* mgmt_v3_lock in glusterd_conf_t
* List of connected clients
* uuid of glusterd
* A section of rpc related information like live connections and their
statistics
There are couple of issues which were found during implementation and testing
phase:
- xaction_peers of glusterd_conf_t was not initialized in init because of which
traversing through this list head was crashing when there was no active
transaction
- gf_free was not setting the typestr to NULL if the the alloc count becomes 0
for a mem-type earlier allocated.
Change-Id: Ic9bce2d57682fc1771cd2bc6af0b7316ecbc761f
BUG: 1139682
Signed-off-by: Atin Mukherjee <amukherj@redhat.com>
Reviewed-on: http://review.gluster.org/8665
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Kaushal M <kaushal@redhat.com>
Diffstat (limited to 'xlators/protocol')
| -rw-r--r-- | xlators/protocol/client/src/client-rpc-fops.c | 2 | ||||
| -rw-r--r-- | xlators/protocol/server/src/server-rpc-fops.c | 2 |
2 files changed, 2 insertions, 2 deletions
diff --git a/xlators/protocol/client/src/client-rpc-fops.c b/xlators/protocol/client/src/client-rpc-fops.c index 47e49502595..d02206b3ed9 100644 --- a/xlators/protocol/client/src/client-rpc-fops.c +++ b/xlators/protocol/client/src/client-rpc-fops.c @@ -2832,7 +2832,7 @@ client3_3_readv_cbk (struct rpc_req *req, struct iovec *iov, int count, rsp.op_errno, out); #ifdef GF_TESTING_IO_XDATA - dict_dump (xdata); + dict_dump_to_log (xdata); #endif out: diff --git a/xlators/protocol/server/src/server-rpc-fops.c b/xlators/protocol/server/src/server-rpc-fops.c index 0438fb971c3..2337deb6dc1 100644 --- a/xlators/protocol/server/src/server-rpc-fops.c +++ b/xlators/protocol/server/src/server-rpc-fops.c @@ -3787,7 +3787,7 @@ server3_3_writev (rpcsvc_request_t *req) op_errno, out); #ifdef GF_TESTING_IO_XDATA - dict_dump (state->xdata); + dict_dump_to_log (state->xdata); #endif ret = 0; |