diff options
author | Niels de Vos <ndevos@redhat.com> | 2015-05-18 16:26:02 +0200 |
---|---|---|
committer | Pranith Kumar Karampuri <pkarampu@redhat.com> | 2015-05-29 05:43:17 -0700 |
commit | 8a9328e37b8c63d60583184dc8dab12f85810682 (patch) | |
tree | 0fa017379bf5e9dfaa2e6d8132c73cc1090a3d52 /xlators/storage/bd | |
parent | 5d912230a7d4f9979c10ff15da724624bd8e069d (diff) |
build: do not #include "config.h" in each file
Instead of including config.h in each file, and have the additional
config.h included from the compiler commandline (-include option).
When a .c file tests for a certain #define, and config.h was not
included, incorrect assumtions were made. With this change, it can not
happen again.
BUG: 1222319
Change-Id: I4f9097b8740b81ecfe8b218d52ca50361f74cb64
Signed-off-by: Niels de Vos <ndevos@redhat.com>
Reviewed-on: http://review.gluster.org/10808
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Tested-by: NetBSD Build System
Reviewed-by: Kaleb KEITHLEY <kkeithle@redhat.com>
Reviewed-by: Pranith Kumar Karampuri <pkarampu@redhat.com>
Diffstat (limited to 'xlators/storage/bd')
-rw-r--r-- | xlators/storage/bd/src/bd-aio.c | 5 | ||||
-rw-r--r-- | xlators/storage/bd/src/bd-aio.h | 5 | ||||
-rw-r--r-- | xlators/storage/bd/src/bd-helper.c | 4 | ||||
-rw-r--r-- | xlators/storage/bd/src/bd.c | 4 | ||||
-rw-r--r-- | xlators/storage/bd/src/bd.h | 5 |
5 files changed, 0 insertions, 23 deletions
diff --git a/xlators/storage/bd/src/bd-aio.c b/xlators/storage/bd/src/bd-aio.c index 9dc13b3ec60..191d23d10b0 100644 --- a/xlators/storage/bd/src/bd-aio.c +++ b/xlators/storage/bd/src/bd-aio.c @@ -13,11 +13,6 @@ cases as published by the Free Software Foundation. */ -#ifndef _CONFIG_H -#define _CONFIG_H -#include "config.h" -#endif - #include <lvm2app.h> #include <sys/uio.h> diff --git a/xlators/storage/bd/src/bd-aio.h b/xlators/storage/bd/src/bd-aio.h index 16f686a4caa..82386e0b072 100644 --- a/xlators/storage/bd/src/bd-aio.h +++ b/xlators/storage/bd/src/bd-aio.h @@ -11,11 +11,6 @@ #ifndef _BD_AIO_H #define _BD_AIO_H -#ifndef _CONFIG_H -#define _CONFIG_H -#include "config.h" -#endif - #include "xlator.h" #include "glusterfs.h" diff --git a/xlators/storage/bd/src/bd-helper.c b/xlators/storage/bd/src/bd-helper.c index 8aaffa6b27a..cf50ba5e7d9 100644 --- a/xlators/storage/bd/src/bd-helper.c +++ b/xlators/storage/bd/src/bd-helper.c @@ -1,7 +1,3 @@ -#ifndef _CONFIG_H -#define _CONFIG_H -#include "config.h" -#endif #include <lvm2app.h> #ifdef HAVE_LIBAIO #include <libaio.h> diff --git a/xlators/storage/bd/src/bd.c b/xlators/storage/bd/src/bd.c index 4ef94810f99..f732b85f030 100644 --- a/xlators/storage/bd/src/bd.c +++ b/xlators/storage/bd/src/bd.c @@ -17,10 +17,6 @@ cases as published by the Free Software Foundation. */ -#ifndef _CONFIG_H -#define _CONFIG_H -#include "config.h" -#endif #include <lvm2app.h> #include <openssl/md5.h> #include <time.h> diff --git a/xlators/storage/bd/src/bd.h b/xlators/storage/bd/src/bd.h index 3491349f2e4..bdaf6f032d9 100644 --- a/xlators/storage/bd/src/bd.h +++ b/xlators/storage/bd/src/bd.h @@ -18,11 +18,6 @@ #ifndef _BD_H #define _BD_H -#ifndef _CONFIG_H -#define _CONFIG_H -#include "config.h" -#endif - #ifdef HAVE_LIBAIO #include <libaio.h> #endif |